Git Product home page Git Product logo

Comments (10)

fulopattila122 avatar fulopattila122 commented on May 22, 2024 1

It's been released in framework v0.4.1.
To get the update run: composer update vanilo/framework

Thanks again for the report + the suggestion.

from demo.

j-dohnalek avatar j-dohnalek commented on May 22, 2024

Do not know if this helps spatie/laravel-medialibrary#646

from demo.

fulopattila122 avatar fulopattila122 commented on May 22, 2024

Vanilo v0.4 was released yesterday. Please use a fresh new install and check if that works.
We've been testing it excessively in the last few weeks and haven't had this error, so it should work.

from demo.

j-dohnalek avatar j-dohnalek commented on May 22, 2024

I have installed the version 0.4 and there are two problems.
First when creating new product and attempting to upload a picture there is no button to submit the picture and the picture is not uploaded with the creation of the product.

Create form - No Submit
image
Edit form - Submit
image

Second problem is the one I have highlighted yesterday. When I am on product edit page and just click the green submit button to upload a picture it will throw exception.

from demo.

fulopattila122 avatar fulopattila122 commented on May 22, 2024

Hmm ok.., thanks for the report, I'll look into it shortly.

from demo.

j-dohnalek avatar j-dohnalek commented on May 22, 2024

I am just having a look around the 0.4 now and the upload of files when creating products works. It it just the edit exception.

from demo.

fulopattila122 avatar fulopattila122 commented on May 22, 2024

Do you mean that the only problem is when you submit Images on product edit form without files selected with the green arrow?

from demo.

j-dohnalek avatar j-dohnalek commented on May 22, 2024

Yes

from demo.

j-dohnalek avatar j-dohnalek commented on May 22, 2024

I have changed Vanilo\Framework\Http\Controllers\MediaController@store
to

public function store(Request $request)
{
        if(!$request->has('images')){
            flash()->error(__('No image supplied, image is required!'));
            return redirect()->back();
        }

        // Laravel Black Magic
        $model = app(concord()->short($request->get('forType')))->find($request->get('forId'));

        $model->addMultipleMediaFromRequest(['images'])->each(function ($fileAdder) {
            $fileAdder->toMediaCollection();
        });

        flash()->success(__('Images have been added successfully!'));
        return redirect()->back();
}

and the exception is not triggered

from demo.

fulopattila122 avatar fulopattila122 commented on May 22, 2024

Ok, I'll add that validation to the framework

from demo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.