[CRASH] If you have version.script file, make sure update Redis* to Valkey* about valkey HOT 9 OPEN

Yes, thus any client has the file like this, client need to be updated by itself.

I wonder if we should take a code fix to remove this line altogether. If someone is bringing over a Redis module in the source code format, I think we should honor that intent by not changing their entry point. thoughts?

from valkey.

I guess I'm still a bit confused, is there a test you can write that will demonstrate the behavior?

from valkey.

The module in question is built against the Valkey source tree where RedisModule_OnLoad is aliased to ValkeyModule_OnLoad. The version script says that all symbols except for RedisModule_OnLoad should be hidden, which includes ValkeyModule_OnLoad hence this issue. Since we have decided to be both source and ABI compatiable with Redis modules, I think we can try fixing this issue by deleting https://github.com/valkey-io/valkey/blob/unstable/src/redismodule.h#L339

However, we will print out a "Legacy module ... loaded" NOTICE message with this change, even if the module is rebuilt against the Valkey tree. This is probably acceptable as the module is written against redismodule.h. So technically it is still a legacy Redis module.

from valkey.

I guess I'm still a bit confused, is there a test you can write that will demonstrate the behavior?

Let me try to describe this issue by using an example

from valkey.

I guess I'm still a bit confused, is there a test you can write that will demonstrate the behavior?

I already update the top comment to describe an example for this issue, Thanks

from valkey.

@hwware the macro on L339 in redismodule.h is the cultprit.

from valkey.

@hwware the macro on L339 in redismodule.h is the cultprit.

Yes, thus any client has the file like this, client need to be updated by itself.

from valkey.

@hwware How critical is this to fix? Do we need to pull it in to the Valkey 8 project?

from valkey.

I have no idea how it is important. But any project includes vesion.script as the example in the top comment, some codes changes need. Let us have a vote for core member @valkey-io/core-team : do we need to pull it in to the Valkey 8 project?

from valkey.