Comments (4)
The other half of the same struct is related to the cluster bus. Is it worth splitting the struct?
The current abstraction is that the clusterbus owns the underlying struct, and can define whatever implementation it wants for modifying the data. It just needs to provide a coherent external API for cluster.c. I'm not exactly sure how we would split it.
from valkey.
@PingXie Thoughts ^
from valkey.
Here are the cluster subcommands from commands.def
These are the subcommands that are flagged as CMD_ADMIN:
addslots
addslotsrange
bumpepoch
count-failure-reports
delslots
delslotsrange
failover
flushslots
forget
meet
replicas
replicate
reset
saveconfig
set-config-epoch
setslot
slaves
These are the rest of the subcommands:
countkeysinslot
getkeysinslot
help
info
keyslot
links
myid
myshardid
nodes
shards
slots
from valkey.
cluster_legacy.(c|h): These files include all of the code for maintaining the clusterbus and the internal topology it maintains. It will maintain the administration commands for manipulating that topology.
Half of the clusterNode struct is client facing information, like a node's name, its slots, IP, port, TLS port, it's replicas, etc. This information is often accessed from cluster.c for various client-facing commands.
The other half of the same struct is related to the cluster bus. Is it worth splitting the struct?
from valkey.
Related Issues (20)
- [NEW] Module support for Sentinels HOT 4
- [NEW][Feature Request] TTL for keys within the HASH data type HOT 2
- [BUG] Lua libs and functions aren't replicated on a cluster HOT 2
- [NEW] Output logs as JSON HOT 4
- Follow up on the capability flag during cluster meet
- [NEW] sentinel shouldn't pick slaves that are not synced with master #13533
- Stale `PONG` message causes incorrect `replicaof` updates leading to `replicaof` loops
- [Test issue] The tests don't correctly reflect the number of tests left HOT 4
- [BUG] Using more sentinels than io-threads causes high idle CPU usage on leader HOT 2
- Benchmark results for 8.0.0-rc2 vs 7.2.6 using single thread HOT 6
- [BUG] Please stop including tcmalloc.h via google/tcmalloc.h HOT 1
- [Test failure] Migrated replica reports zero repl offset and rank HOT 2
- [Test failure] Instance #0, #1, #2 gets converted into a slaves HOT 1
- [Test failure] valkey-cli make source node ignores NOREPLICAS error when doing the last CLUSTER SETSLOT HOT 4
- Add [Dual Channel] Tag for Dual Channel Server Logs HOT 1
- [NEW] New data structure for TTL HOT 2
- Implement new hash table
- Embed key and TTL in robj HOT 5
- [CRASH] Assertion failed: pthread_mutex_unlock HOT 9
- [BUG] slot stuck in importing state on replica after scale-up and rebalance HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valkey.