Git Product home page Git Product logo

Comments (4)

valentinacupac avatar valentinacupac commented on May 18, 2024

Thanks @adrianliz for this contribution!

I merged the PR onto main.

5 tests fail on GitHub Actions https://github.com/valentinacupac/banking-kata-java/actions/runs/3788330027/jobs/6440993780

BankingApplicationTests > contextLoads() FAILED
    java.lang.IllegalStateException at DefaultCacheAwareContextLoaderDelegate.java:132
        Caused by: java.lang.IllegalStateException at SpringBootCondition.java:60
            Caused by: java.lang.IllegalArgumentException at PropertyPlaceholderHelper.java:180

JpaBankAccountStorageTest > should_return_empty_given_non_existent_account_number() FAILED
    org.junit.jupiter.api.extension.ParameterResolutionException at ExecutableInvoker.java:2[39](https://github.com/valentinacupac/banking-kata-java/actions/runs/3788330027/jobs/6440993780#step:8:40)
        Caused by: java.lang.IllegalStateException at DefaultCacheAwareContextLoaderDelegate.java:132
            Caused by: java.lang.IllegalStateException at SpringBootCondition.java:[60](https://github.com/valentinacupac/banking-kata-java/actions/runs/3788330027/jobs/6440993780#step:8:61)
                Caused by: java.lang.IllegalArgumentException at PropertyPlaceholderHelper.java:180

JpaBankAccountStorageTest > should_return_added_bank_account() FAILED
    org.junit.jupiter.api.extension.ParameterResolutionException at ExecutableInvoker.java:239
        Caused by: java.lang.IllegalStateException at DefaultCacheAwareContextLoaderDelegate.java:132
            Caused by: java.lang.IllegalStateException at SpringBootCondition.java:60
                Caused by: java.lang.IllegalArgumentException at PropertyPlaceholderHelper.java:180

JpaBankAccountStorageTest > should_find_multiple_added_bank_accounts() FAILED
    org.junit.jupiter.api.extension.ParameterResolutionException at ExecutableInvoker.java:239
        Caused by: java.lang.IllegalStateException at DefaultCacheAwareContextLoaderDelegate.java:132
            Caused by: java.lang.IllegalStateException at SpringBootCondition.java:60
                Caused by: java.lang.IllegalArgumentException at PropertyPlaceholderHelper.java:180

BankAccountControllerSystemTest > should_open_account_given_valid_request() FAILED
    org.junit.jupiter.api.extension.ParameterResolutionException at ExecutableInvoker.java:239
        Caused by: java.lang.IllegalStateException at DefaultCacheAwareContextLoaderDelegate.java:132
            Caused by: java.lang.IllegalStateException at SpringBootCondition.java:60
                Caused by: java.lang.IllegalArgumentException at PropertyPlaceholderHelper.java:180

108 tests completed, 5 failed

Now locally, when the environment variables are set, everything works, but just fails on GitHub Actions...

What are your results when you run locally?

I will try to check, and if you have any ideas feel free to try too...

from banking-kata-java.

valentinacupac avatar valentinacupac commented on May 18, 2024

Sorry, the issue seems to be about Postgres now (so not related to KeyCloak), so I opened up a new ticket #57.

from banking-kata-java.

valentinacupac avatar valentinacupac commented on May 18, 2024

Now the only remaining topic is the system test.

I was receiving the failure for the test BankAccountControllerSystemTest.should_open_account_given_valid_request

org.springframework.web.reactive.function.client.WebClientRequestException: Connection refused: no further information: localhost/127.0.0.1:10000; nested exception is io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: no further information: localhost/127.0.0.1:10000

The detailed log is in ticket #58. In that ticket I have commented out the security-related code (ef5ba9c) since that was the only way to make the test BankAccountControllerSystemTest.should_open_account_given_valid_request to continue to pass, until we resolve the issue.

@adrianliz could you also try to run the test suite locally (with & without security) and let me know what results you get. When I tested it, both locally and on GitHub Actions, it works without security, but fails when we have the security code... I'm trying to investigate this...

from banking-kata-java.

valentinacupac avatar valentinacupac commented on May 18, 2024

I am closing this ticket, we can continue on #58 to resolve the open issue.

from banking-kata-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.