Git Product home page Git Product logo

Comments (5)

vaibhavsingh97 avatar vaibhavsingh97 commented on July 20, 2024

Hi @ErikBoesen
Yes, we can do so, but will you pass API as a parameter every time?
As currently, while initiating the package, API key is initialized and available to all the methods to call as API. Please let me know your thoughts on this, how we can improve?

from random-word.

ErikBoesen avatar ErikBoesen commented on July 20, 2024

I see now from a closer look that you do instantiate the API each time. But my concern is that there's not really any variation in how you do this, so you might as well instantiate it automatically since there's no API key being passed.

Also I as a user would prefer to not have many different names. Right now it uses random-word, random_word, and RandomWords. I would standardize around random_word and RandomWord if I were you.

from random-word.

ErikBoesen avatar ErikBoesen commented on July 20, 2024

I'll make a PR in a bit.

from random-word.

vaibhavsingh97 avatar vaibhavsingh97 commented on July 20, 2024

@ErikBoesen Any update?

from random-word.

vaibhavsingh97 avatar vaibhavsingh97 commented on July 20, 2024

Closing this issue, as in new update user will have the option to pass API of their own

from random-word.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.