Comments (7)
Artur-
commented on August 23, 2024
2
Can't the recipe be changed to apply theme="dark" only to the recipe itself or even some part inside the recipe?
from cookbook.
github-actions
commented on August 23, 2024
There has not been any activity on this issue for 60 days and it is going to be marked as stale and closed in 7 days.
from cookbook.
samie
commented on August 23, 2024
Not only does it apply the CSS persistently, but the dark mode texts are now also unreadable. @jouni Do you have time to investigate and help fixing this?
from cookbook.
jouni
commented on August 23, 2024
As a quick workaround, I would comment out the @jsmodule from the recipe, to avoid running the script, and add a comment above to explain why.
from cookbook.
jouni
commented on August 23, 2024
Not sure what the best fix here is in the end. Running an example inside an iframe would be one solution.
In any case, we can't set the <html theme="dark"> attribute as long as Lumo is loaded in the global and Antlers does not support a dark mode. We’ve made a custom dark mode theme for Antlers in Docs, that makes these two work together nicely.
And even then, I would say it’s strange that one recipe will affect all others (by swapping the color palette). Either we use an iframe, or we need to emulate the OS preference and show a different code snippet for the visitors.
from cookbook.
github-actions
commented on August 23, 2024
There has not been any activity on this issue for 60 days and it is going to be marked as stale and closed in 7 days.
from cookbook.
github-actions
commented on August 23, 2024
There has not been any activity on this issue for 60 days and it is going to be marked as stale and closed in 7 days.
from cookbook.
Related Issues (20)
- How do I select Grid rows automatically using up/down arrow keys
- How do I print a subset of components
- Remove app-specific code from preview HOT 1
- Enable HaaSv2 as part of the new website design HOT 1
- Example "Add template renderer in grid and handle events" did not work as expected HOT 4
- How do I make a AbsluteLayout in Vaadin 14 HOT 1
- The "textfield-label-left" recipe does not work with Vaadin 22 HOT 1
- grid-row-height recipe doesn't show accompanying CSS file HOT 5
- [bug] global css styles missing on navigating HOT 5
- Recipes with multiple CSS files only show one HOT 1
- Improvements to recursive TreeGrid selection HOT 1
- How do I style lit elements with Vaadin? HOT 1
- Issue in recipe title and cookbook header styles after opening a recipe HOT 1
- How do I create a clickable link inside a Grid cell
- How do I I need to use cookbook with vaadin version 24.0.0 & hilla 2.0.0 HOT 1
- How do I display more than one validation message at a time? HOT 1
- Fix the TreeGrid hierarchy column example HOT 1
- Vaadin Tabs with Routes example is having some bugs HOT 1
- Bug in grid-dense-theme Recipe HOT 1
- How do I export data like grid or any DTO class to PDF HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cookbook.