[0.9] Follow link in new window (Fl) fails in uzbl-browser about uzbl HOT 11 CLOSED

Actually looks like it's just missing a 'newwindow' tag as the last argument to follow.sh

from uzbl.

Note: At least for the 0.9rc no trigger seems to be set off upon finishing input. I.e. when the keyboard hint is the number 2, upon entering Fl2, the text just remains there as such in the keycmd_section.

(Whereas with lower case fl it would vanish and load the according link instead.)

from uzbl.

@keis: Where?

This is the binding as declared in the default config:

@cbind  Fl*  = spawn @scripts_dir/follow.sh \@< uzbl.follow.followLinks("\@follow_hint_keys", "%s", 'newwindow') >\@

from uzbl.

@cbind  Fl*  = spawn @scripts_dir/follow.sh \@< uzbl.follow.followLinks("\@follow_hint_keys", "%s", 'newwindow') >\@ newwindow

like so, but even without that the typed stuff is still getting cleared

from uzbl.

Strange. Now that I did some playing around (changing NEW_WINDOW to sh -c uzbl-browser ..., then /usr/bin/uzbl-browser ... and back to the original value) it works.

However, there is a delay of up to 2 seconds once the last char (digit) of the key hint is entered.

Which shell is used by/for spawn_sh?

from uzbl.

@GSI: Whatever is configured for your user (we use g_spawn).

As for the delay, that is probably the event queue not being flushed properly. I fixed some of it with the buffered-io branch (#137), but maybe some flush calls need to be made when uzbl-core writes to its outputs?

from uzbl.

How are we managing changes that should go into master and next? Two PR's? Or will you cherry-pick?

from uzbl.

PR to master, merge into next. If it has webkit2-related things, branch off next and merge directly into next.

from uzbl.

I believe this is fixed now

from uzbl.

from uzbl.

If you find anything that could help reproduce that please open an issue. Some ideas on things to try

• Does it happen running uzbl-browser from the terminal or only from within a running browser
• Does it happen (more often) with certain urls?
• Does it happen running a uzbl-core without connecting to the em
• Does it happen running a uzbl-core without config and without connecting to the em

from uzbl.