Comments (4)
If using the name from the author profile, assuming that you are referring to the JSON file, SB+ would have to request and parse the JSON file for a short string that is only used in two places: splash screen and the black title bar. The splash screen would not be displayed again during a viewing "session." So, it will be only be displayed in the title bar.
Currently, I had it load only when user requested it (to see the author profile) because some users may not open the author profile under menu at all during the "session." It would be one less item to request from the server. Instead of always on demand, it would be load on demand.
Is there a reason why the name in XML would be different from the name in JSON file? To me, this should be like a best practice to have the name in the XML and JSON to be the same. Plus, this provides the flexibility to display different "information" at two places for some situations instead of being determined by the information in a centralized JSON file, which may not even exist.
Thoughts? @patrick-wirth and @mwolfensteinuwex if you have the time to spare.
from sbplus-v3.
Implemented in version 3.1.
from sbplus-v3.
This regressed. And I have an example of a use case that I was anticipating.
Example presentation:
https://media.uwex.edu/content/abt/abt715/abt715_electrochemistry.sbproj/
Name:
/content/media/player_support/author/francismann.jpg
/content/media/player_support/author/francismann.json
Desired Name:
Francis "Frannie" Mann
from sbplus-v3.
Fixed. The author's name on splash screen and on the black bar is now retrieved from the JSON file. Default to the name in XML if no JSON is available. Please confirm the fix. Close the issue if the fix satisfies the request. Thank you.
from sbplus-v3.
Related Issues (20)
- The quiz engine displays the incorrect feedback after navigating past a quiz item and then returning to it later HOT 1
- HTML page type to allow true/false value for embed attribute
- Storybook Pages that are HTML Open in a New Window by Default - I think this should be reversed HOT 2
- TESTING HOT 2
- TESTING HOT 1
- Test HOT 1
- Another test HOT 2
- Black box in presentation HOT 1
- Ampersands to not render correctly in webpage titles.
- Explore/Implement an official XML Schema for Storybook HOT 3
- Notes Section Stops Rendering When you Return to It HOT 1
- Author profile does not scroll for longer contents HOT 2
- Presentations made by the Packager do not Properly Display Downloadable Assets HOT 3
- Long link does not wrap to next line in Notes HOT 1
- Remove Cache on XML HOT 3
- Work around an issue with SVGs not rendering inline raster images in Safari HOT 6
- Table of Content does not scroll to the begin after click next on the last page HOT 1
- Update Kaltura videos to load the default thumbnail from Kaltura HOT 2
- Auto-generated YouTube CCs HOT 2
- GA not tracking lesson made with the packager app HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbplus-v3.