Comments (6)
To see commit for the bug fix, go to ca6594c
from uw-2014.
Note: attached to uweb/uw-slideshow@e8d9187 of uw-slideshow plugin
from uw-2014.
Hey folks,
I grabbed the changes to the slideshow from the master branch and rebuilt our child theme to incorporate it. I sent our internal ticket back to our tester, and he added more feedback.
It looks like the items we reported haven't quite been addressed, and a few more issues have popped up.
Here's the updated Actual Result section of the ticket:
Actual Result:
- Slider/slideshow is not highlighted, the only way user can tell where they are is by reading the URL in lower left corner of browser screen.
- Each slide story has two tab stops instead of one, and while using the tab key, images sometimes change.
- Each of the major browsers behave slightly differently for navigation:
- In Chrome, the only navigation in the carousel is the tab key. Arrow keys do not seem to do anything. When the user hits enter there is no response from the page.
- In Firefox navigation is also the tab key, and pressing the enter key will activate the link that is highlighted navigating to the appropriate page.
- In Internet Explorer 11 the user can use tab to get to the carousel, then use the arrow keys to navigate the carousel but using enter does not open the article selected.
- The user can only hit backspace to leave the slide story and that takes them back to the top of the Research home page instead of to the slide carousel where they were previously.
We also wanted to see whether the changes to the slideshow affected other pages than ours, so we went to the HTML Components entry on the brand site and noticed the slide show demo was broken.
from uw-2014.
Hi,
Looking at your review, I am not experiencing the same issues. It may be the environment I set up, but just to be sure, I wanted to know if you had downloaded both changes. The first being from the UW-2014 theme, and the second being the update to the uw-slideshow plugin that I linked above. Just wanted to check both files had been updated.
Thanks,
Nick
from uw-2014.
Hi,
This is Matt Lambert on the ORIS web team. I work with Greg, who logged this original bug. We have done some thinking and comparing with keyboard accessibility patterns found on other pages, and we have come to the conclusion that TAB navigation should not be enabled within the slideshow component. The slideshow itself should have a tab-stop, and the slideshow element should be outlined or highlighted in a way that indicates it has focus. But while focus is on the slideshow, a keyboard navigating user should be able to navigate from slide to slide using the arrow keys. Hitting TAB when focus is on the slideshow should cause focus to move to the next element on the page.
As a result of this, we would like to consider the following areas:
- Keyboard arrow navigation within the slideshow: this seems to be working correctly, so nothing is needed here.
- Slideshow element visibly displaying focus to the user: the element shows a subtle outline in Firefox (40.0.3) when it has focus. But I do not see any visible indication of focus in either IE (11.0.9600) or Chrome (45.0.2454.99 m). I will log a separate bug to address this.
- TAB navigation within the slideshow: currently, when a user hits either TAB and SHIFT-TAB (reverse-direction) while focus is on the slideshow element, slides will advance forward through the slideshow. As I stated above, we now believe TAB navigation should not be enabled within the slideshow. I will log a new bug to address this.
Thanks,
Matt
from uw-2014.
Hi Matt,
Thank you for looking more into what other sites are doing. Go ahead and log the issues as new bugs, and we will add them to the to-do list.
Thanks,
Nick
from uw-2014.
Related Issues (20)
- Remove "Download" link from image attachment page HOT 5
- button visible in dawgdrop-item HOT 1
- Widget / shortcode heading bugs HOT 1
- Accordion keyboard interactivity
- media-credit.js causing errors HOT 2
- Lightbox interactions
- update to jQuery 3.x HOT 2
- Missing documentation for Accordion shortcode URL detection HOT 3
- Javascript error when interacting with PDF files HOT 2
- Mobile search issue HOT 1
- Page Revisions cannot be viewed, restored HOT 3
- embedded google maps get transformed into broken calendar shortcodes HOT 1
- Media credit issues HOT 1
- Text widget issues in WP 5.8.1 HOT 1
- version in theme header HOT 3
- Bug in class.button-shortcode.php HOT 5
- Empty container in right sidebar of some pages HOT 2
- version number doesn't match release
- can you give demo content
- [WP 6.4.1 and PHP 8.2.13] PHP Fatal error: Uncaught TypeError: Unsupported operand types::in .../widgets/class.uw-widget-visibility.php:440
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uw-2014.