Git Product home page Git Product logo

Comments (13)

SpenceJMNelson avatar SpenceJMNelson commented on August 20, 2024 1

@matbrady if possible suggest surrounding colored regions with a white border instead of trying to add different textures to the states. @lizzycederberg @lfrancis do you think this solves the problem?
100922521-ff2b1e80-34ab-11eb-8bc1-ca603b1aef61

from nara-bia-photos.

SpenceJMNelson avatar SpenceJMNelson commented on August 20, 2024 1

spoke with mat on slack and the map doesn't support grouping state shapes together and drawing a line around that group, so mat is going to try using moving different regions apart so there's space around them

from nara-bia-photos.

matbrady avatar matbrady commented on August 20, 2024

The drop-down helps for accessibility, but because it doesn’t provide the same information (the regions),

@lizzycederberg If they are referring to the record count, that was updated in #206. It's been updated in the test env, but likely not on the live site.

from nara-bia-photos.

lizzycederberg avatar lizzycederberg commented on August 20, 2024

I think they are saying the contrast between the colors of adjacent regions is not high enough for someone who is color blind to be able to clearly determine where one starts and one ends, e.g. the Eastern region and the Midwest region are pretty close in color: https://bia.test.drupalme.net/research/native-americans/bia/photos/states

So really we need a new design for the map that uses textures instead of colors (or in addition to colors maybe) to help those users.

Screen Shot 2020-12-02 at 2 36 34 PM

from nara-bia-photos.

lfrancis avatar lfrancis commented on August 20, 2024

The existing colors are fine in the three major color-blind types until you get to grayscale, which is the rarest of all -- that 8% figure cited above covers mostly the three major types of deficiencies.

You can test this yourself on MacOS with the Accessibility Control Pane by turning on color filters:
image

from nara-bia-photos.

matbrady avatar matbrady commented on August 20, 2024

I think they are saying the contrast between the colors of adjacent regions is not high enough for someone who is color blind to be able to clearly determine where one starts and one ends,

@lizzycederberg I was just mentioning that if the select is fully accessible and provides the same content, it doesn't sound like there is a need to correct the colors further.

from nara-bia-photos.

lizzycederberg avatar lizzycederberg commented on August 20, 2024

@matbrady @SpenceJMNelson I asked NARA if adding the regions to the drop down was an acceptable alternative and they said:

Including the regions for each state in the dropdown, along with a header for each region that lists each state included in that region, will provide comparable information.

I'm not sure I understand that. What do you think?

from nara-bia-photos.

matbrady avatar matbrady commented on August 20, 2024

@lizzycederberg I don't fully understand this or why we asked to add regions to the dropdown if the original issue was for color contrast.

from nara-bia-photos.

lfrancis avatar lfrancis commented on August 20, 2024

@lizzycederberg I don't fully understand this or why we asked to add regions to the dropdown if the original issue was for color contrast.

I think what they we're saying was -- in the absence of additional colorblind measures -- adding the region header to the states select solves the accessibility problem.

from nara-bia-photos.

lizzycederberg avatar lizzycederberg commented on August 20, 2024

@matbrady I don't see anything different on the page. Did you make a change?

from nara-bia-photos.

lizzycederberg avatar lizzycederberg commented on August 20, 2024

We will move some colors around so the regions are not close to other regions with similar colors and update the drop down with regions

from nara-bia-photos.

lfrancis avatar lfrancis commented on August 20, 2024

Confirmed addressed

from nara-bia-photos.

lizzycederberg avatar lizzycederberg commented on August 20, 2024

Looks good! Just reopening until I send the update to NARA

from nara-bia-photos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.