Comments (1)
These may not get resolved for future features adds:
nitpick 1: TADA_DATA_URL and the URL for domain tables are only used by one function each, but the plan is for additional resources on both to be able to be used by future feature adds. For example new crosswalks with the upcoming transition from WQX2.0 -> 3.0
discussion 1: these were moved around to avoid cyclic imports
todo 2 (basis.py): These additional basis columns haven't received much attention yet. It was coded this was to make it easy to come back to and write additional specific handling. combined weight/time, left particuleSize which has been notes specific to it's handling.
Notes:
Suggestion 1: probably, not sure where to implement yet, not a straightforward groupby
Suggestion 2: check other modules
Suggestion 3: made these dicts, but need to move docs to module level. domains.out_col_lookup(), domains.xy_datum(), domains.stations_rename(), domains.accepted_methods(), basis.basis_conversion(), basis.stp_dict()
Suggestion 4: conductivity_to_PSU has references, references for methods/model, if for code/checks it goes in source code.
Suggestion 5: numpy.where is great, but in the provided example existing columns values need to be left alone so this will require a if/else. numpy.where will coerce the other values (y) to the dtype which is problematic for nan. There are fixes, but simple is better than complex.
from harmonize-wq.
Related Issues (20)
- Bring up to date with latest versions?
- Catch error for unrecognized units with 'NoneType'
- Expand methods filtering
- Capitalization in units HOT 1
- Basis not writing to Speciation
- u_reg used for convert decorators HOT 1
- Allow PERIODIC_MW used by conversions to be user updated?
- Consistent table format for example workflow section: Transform results from long to wide format
- Use period of record to check for data updates
- Check for duplicate axis label when coercing measure
- doc_test stability
- Generalize wet_dry functions in clean module
- Review edits - Harmonize_Pensacola.Rmd
- Review RC [doc]: environment instructions for dev HOT 3
- Review RC: tests not passing HOT 1
- Review RC [feature]: use automated tool for requirements
- Review RC [doc]: link the different example from README to doc / Add link to documentation
- Review RC [doc]: add citation
- RC review [doc]: example not complete
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from harmonize-wq.