FBS: some NAICS dropping about flowsa HOT 8 CLOSED

@bl-young Thanks for pointing this issue out. It is a necessary step for some of the mappings I'm working with. I moved the "add_sectors_to_flowbyactivity" into the for loop that runs through each of the activities in the "names" list of an activity set. This way the NAICS are assigned to each SCC, one at a time, so the NAICS shouldn't be dropped.

from flowsa.

@bl-young let us know if this is still a problem or otherwise go ahead and close, thanks

from flowsa.

I'm still getting unexpected results where the allocation to sectors is wrong. I will post a more detailed update.

from flowsa.

Its still unclear to me why we are removing NAICS in line 119 that already exist in the mapping file

from flowsa.

Ok - I see how the current method of implementation can cause problems. The objective is to prevent existing data from being overwritten. For instance, in the USDA_IWMS mapping, we have:
ORCHARDS =1113
BERRY TOTALS =111334
I want the water application rates (acre-feet/acre) for orchards disaggregated to naics6, but I don't want the acre-feet/acre for berry totals to be overwritten by the orchards value, so I was dropping the mapping 1113 -> 111334.
The code needs to be revised so it doesn't blanket drop existing NAICS. Let me think about it...

from flowsa.

But wouldn't you still want the value included in Orchards to apply to Berries just like all other subsets of 1113?

from flowsa.

The issue is with how I set up the crosswalk for USDA IWMS. We can remove line 119 (and associated code).

from flowsa.

resolved here

from flowsa.