Comments (5)
Currently the dataset types menu has an action listener, typeAction()
For a JComboBox, the action listener gets called whenever an item is selected. This means that typing in a single letter will fire the action event (because almost every letter matches a dataset type), which isn't what we want so this action listener needs to be removed.
I see three different ways of interacting with the dataset types menu:
- With the mouse, the user opens the popup menu and clicks on the item. A PopupMenuListener for popupMenuWillBecomeInvisible() seems like it should work in this case.
- The user opens the popup menu (either with the mouse or keyboard), uses the up and down arrows to select an item or types letters, then hits Enter to close the popup. The same popupMenuWillBecomeInvisible listener should be good here.
- The user never opens the popup menu, just types letters to select an item. I'm not sure how this case should work in terms of user expectations. Right now (with the action listener removed), the user can tab to the Name Contains field and hit Enter to trigger the reload.
So, I'd suggest adding a PopupMenuListener to call typeAction() when the popup menu is closed (becomes invisible), and we'll see how that works out.
from emf.
Catherine, please test in Mac and Windows. I want to make sure it's functioning as expected.
from emf.
Back to square one with the code, the code has basically been reverted back to the original code.
A new set of eyes should look at this in the future.
from emf.
To prevent the datasets from being loaded as soon as a letter is typed, I updated the actionListener to only call typeAction() if the dataset types popup menu is not open.
Then I added a popupMenuWillBecomeInvisible listener to trigger the datasets to load when the popup menu is closed.
I also added in the variable dsTypeLoaded
to keep track of the currently loaded dataset type so that if the user selects the same dataset type the datasets don't bother getting refetched.
from emf.
Looking at commit 1648b60, the problem with that code was the key listener that got added. There's no need to specifically listen for the Enter key being pressed because the default Java behavior does what we want.
from emf.
Related Issues (20)
- suppress duplicate Hibernate warnings in log file
- run Tomcat with SSL for EMF server HOT 7
- handle line breaks in description when exporting files HOT 3
- planning for updated EMF server HOT 3
- error importing control measure database HOT 5
- update EMF client libraries matching v4.2 patch 2 HOT 1
- improve re-enable, change password flow for EMF users
- Clean up old three letter users HOT 1
- All users must use Lan Id as username HOT 3
- support for Tomcat 10 / Jakarta EE
- setup for 2nd EMF instance
- security options for EMF command line client
- Issue editing multiple users in User Manager when sorted HOT 1
- Check status of 'wants Emails' for new users HOT 1
- EMF Client installer updates HOT 3
- EMF proxy error HOT 1
- EMF error with compare datasets HOT 3
- MalformedInputException when downloading exported files HOT 2
- Update the Cost Year menu to include 2019 through 2022 HOT 1
- Update the implementation of cost equation Type 13 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emf.