Git Product home page Git Product logo

Comments (2)

urnathan avatar urnathan commented on July 3, 2024

Yeah, I've kind of left that underspecified. It wasn't clear what the best behaviour would be. I'm not quite sure what the GCC behaviour is.
It does seem reasonable that a truncated block of responses could be sent, once an ERROR response is to be sent, and it does seem reasonable that that causes a disconnection.

from libcody.

boris-kolpackov avatar boris-kolpackov commented on July 3, 2024

It does seem reasonable that a truncated block of responses could be sent, once an ERROR response is to be sent, and it does seem reasonable that that causes a disconnection.

Ok, I will proceed with this semantics then. Specifically, in certain cases I reply with ERROR, truncate the block (so this ERROR is the last response) and close both ends of the pipe.

I'm not quite sure what the GCC behaviour is.

I've tried to reply ERROR to HELLO (which is batched with the MODULE-REPO request), truncate the block and close the pipe. Here is the transcript:

g++-m -std=c++2a -fmodules-ts -fmodule-mapper=<> -x c++ -E -fdirectives-only -o hello.o.ii hello.cxx
  > HELLO 1 GCC '' ;
    MODULE-REPO
  < ERROR 'malformed request HELLO'
hello.cxx: error: failed mapper handshake malformed request HELLO
hello.cxx:3:10: error: cannot determine ‘#include’ translation of /home/boris/work/build2/tests/modules/gcc2/gcc-install/include/c++/11.0.0/cassert: communication error:Unknown error -1

[... the same error for each include ...]

So while it seems to be ok with the truncated block, it doesn't seem to handle the closed pipe well. Perhaps an error response and closed communication should be interpreted as a fatal error?

from libcody.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.