Comments (2)
Yeah, I've kind of left that underspecified. It wasn't clear what the best behaviour would be. I'm not quite sure what the GCC behaviour is.
It does seem reasonable that a truncated block of responses could be sent, once an ERROR response is to be sent, and it does seem reasonable that that causes a disconnection.
from libcody.
It does seem reasonable that a truncated block of responses could be sent, once an ERROR response is to be sent, and it does seem reasonable that that causes a disconnection.
Ok, I will proceed with this semantics then. Specifically, in certain cases I reply with ERROR
, truncate the block (so this ERROR
is the last response) and close both ends of the pipe.
I'm not quite sure what the GCC behaviour is.
I've tried to reply ERROR
to HELLO
(which is batched with the MODULE-REPO
request), truncate the block and close the pipe. Here is the transcript:
g++-m -std=c++2a -fmodules-ts -fmodule-mapper=<> -x c++ -E -fdirectives-only -o hello.o.ii hello.cxx
> HELLO 1 GCC '' ;
MODULE-REPO
< ERROR 'malformed request HELLO'
hello.cxx: error: failed mapper handshake malformed request HELLO
hello.cxx:3:10: error: cannot determine ‘#include’ translation of /home/boris/work/build2/tests/modules/gcc2/gcc-install/include/c++/11.0.0/cassert: communication error:Unknown error -1
[... the same error for each include ...]
So while it seems to be ok with the truncated block, it doesn't seem to handle the closed pipe well. Perhaps an error response and closed communication should be interpreted as a fatal error?
from libcody.
Related Issues (9)
- Actually use UTF-8 HOT 5
- exceptions & rtti HOT 1
- fatal.cc:42:25: error: ‘SRCDIR’ was not declared in this scope HOT 4
- Clarify whether interleaving requests/responses in a block is allowed HOT 1
- Header unit name to BMI mapping
- Build problem on Solaris 11.3 HOT 3
- Build problem on FreeBSD 12.2
- configure doesn't set c++11 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libcody.