Comments (7)
It actually not needed to be bind to a zone, because that's what AsyncPipe should do... weird...
I will debug it soon.
@kamilkisiela
from meteor-rxjs.
@kamilkisiela I added a new examples directory with angular2 example - it works there great. Also tested with ChangeDetectionStrategy.OnPush
and it works.
from meteor-rxjs.
@dotansimha how does ChangeDetectionStrategy.OnPush relate to this? AsyncPipe doesn't run zone it only marks itself for check (https://github.com/angular/angular/blob/14ee75924b6ae770115f7f260d720efa8bfb576a/modules/%40angular/common/src/pipes/async_pipe.ts#L146).
Vile thing here is that it might seem working for simple examples (when everything happens synchronously), but will fail eventually for more complex once.
There was also an idea to implement own version of AsyncPipe that runs zone.
from meteor-rxjs.
Yeah you are right about OnPush. Do you have an example for a complex scenario? I tried some and it looks like it worked in all of them.
from meteor-rxjs.
@dotansimha I checked and turned out that Meteor.subscribe's callback runs now always in the zone (didn't before). I think the issue can be in the promises. Before Meteor promise could be initialized before zone-aware promise, so it was not patched. Zone.js actually patches everything including websockets. But that peace with promises was lost from patching.
from meteor-rxjs.
@barbatus thanks, I see.
Do you have any way to reproduce? I wan't to have a look on it
from meteor-rxjs.
@dotansimha I am saying I missed this point before. Now .zone
probably not needed at all, except if observables are used out of Angular 2 zone. I'll check it out one more time and probably cleanup some stuff that not needed.
from meteor-rxjs.
Related Issues (20)
- MeteorObservable.call does not seem to be working HOT 2
- ERROR in ./node_modules/rxjs/observable/BoundCallbackObservable.js HOT 3
- Cannot find namespace HOT 4
- There is a way to do this? HOT 2
- Mongo is not defined HOT 7
- Using dburles:collection-helpers package HOT 2
- Does this work with RxJS 6? HOT 6
- No support for ValidatedMethods (method 'objects')
- ObservableCollections are not an instance of Observable HOT 1
- Suggestion: MeteorObservable passing through observables
- ObservableCollection.d.ts: error TS2314: Generic type 'Selector' / 'Modifier' requires 1 type argument(s). HOT 5
- IE11 syntax error
- Use outside of Meteor?
- Action required: Add a Renovate config
- Problem with property zone
- ObservableCursor aliases all lists it passes to callbacks
- Hidden dependency on underscore.js
- No way to recover if ObservableCollection#insert() fails synchronously HOT 1
- support for higher version than angular 7 HOT 4
- Linting errors with zone.js >= v0.11.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meteor-rxjs.