Git Product home page Git Product logo

Comments (7)

dotansimha avatar dotansimha commented on June 12, 2024

It actually not needed to be bind to a zone, because that's what AsyncPipe should do... weird...
I will debug it soon.
@kamilkisiela

from meteor-rxjs.

dotansimha avatar dotansimha commented on June 12, 2024

@kamilkisiela I added a new examples directory with angular2 example - it works there great. Also tested with ChangeDetectionStrategy.OnPush and it works.

from meteor-rxjs.

barbatus avatar barbatus commented on June 12, 2024

@dotansimha how does ChangeDetectionStrategy.OnPush relate to this? AsyncPipe doesn't run zone it only marks itself for check (https://github.com/angular/angular/blob/14ee75924b6ae770115f7f260d720efa8bfb576a/modules/%40angular/common/src/pipes/async_pipe.ts#L146).
Vile thing here is that it might seem working for simple examples (when everything happens synchronously), but will fail eventually for more complex once.
There was also an idea to implement own version of AsyncPipe that runs zone.

from meteor-rxjs.

dotansimha avatar dotansimha commented on June 12, 2024

Yeah you are right about OnPush. Do you have an example for a complex scenario? I tried some and it looks like it worked in all of them.

from meteor-rxjs.

barbatus avatar barbatus commented on June 12, 2024

@dotansimha I checked and turned out that Meteor.subscribe's callback runs now always in the zone (didn't before). I think the issue can be in the promises. Before Meteor promise could be initialized before zone-aware promise, so it was not patched. Zone.js actually patches everything including websockets. But that peace with promises was lost from patching.

from meteor-rxjs.

dotansimha avatar dotansimha commented on June 12, 2024

@barbatus thanks, I see.
Do you have any way to reproduce? I wan't to have a look on it

from meteor-rxjs.

barbatus avatar barbatus commented on June 12, 2024

@dotansimha I am saying I missed this point before. Now .zone probably not needed at all, except if observables are used out of Angular 2 zone. I'll check it out one more time and probably cleanup some stuff that not needed.

from meteor-rxjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.