double free or corruption using detect function of CLandmark about clandmark HOT 5 CLOSED

Hi @lddm,

if I remember correctly, this can happen only when the inappropriate weight vector W is used. Looking at the code this line seems to be suspicious:

typedef float  fl_double_t;

both the CDPM.xml and FDPM.xml are double. There is no check in the code for this so, I guess that causes the problem. The fl_double_t type should be propagated through the CMake compilation. But for now, just please check whether compiling with

typedef double  fl_double_t;

works. Or you can change the .xml models. However this can be done now only through MATLAB interface...

from clandmark.

Hi @lddm,

I have also noticed that you use

CDPM->detect(&img_gray, &bbox[0]);
FDPM->detect(&img_gray, &bbox_corrected[0]);

please use

CDPM->detect_optimized(&img_gray, &bbox[0]);
FDPM->detect_optimized(&img_gray, &bbox_corrected[0]);

the models are generated for the optimized detection only. It won't work as expected with detect.

I have checked it now and it works with the changes I mentioned.

from clandmark.

Hi @uricamic ,
Thanks very much for your quick and complete response. I was reviewing your comments and will try the proposed changes as soon as I have a free minute.

I changed the typedef of the fl_double_t type because in the first test I done the propagation from the CMake wasn't working correctly. Maybe this was caused by an error from my side when configuring the project that consumes the library), now I believe this line is not necessary.The other change of using detect and not detect_optimized was a last minute idea, I will try to rollback that change.

I will let you know the results,
Best regards and thanks again

from clandmark.

Hi @uricamic ,
I have verified and corrected both the definition of the fl_double_t type and the use of the detect_optimized function. Now the demo application that I developed is working correctly. The landmarks position accuracy is really good.

I made some changes in the CMake configuration of the library in order to automate the integration of the library in another project.

I would like to thank you again for the assistance. Please let me know if I can be of any help or if it's useful for you to have the CMake configuration changes or code of the demo application.

Best regards,

from clandmark.

Hi @lddm,

glad to hear that.

If you want, you can share the project or the modifications you made to CMake configuration. Any kind of help is always welcome :)

from clandmark.