[CLOSED] Fix reduction order in Nock spec about urbit HOT 1 CLOSED

Comment by cgyarvin
Tuesday Sep 24, 2013 at 16:37 GMT

No, you're right. It's funny how many obvious errors one can make in a
page of code.

I view cosmetic changes as actually reverting to the original, correct
version. :-) Now, changing the semantics, that would be difficult at this
point...

On Tue, Sep 24, 2013 at 4:53 AM, Aaron Beckerman
[email protected]:

The way one is supposed to use the Nock spec is by repeatedly going
through the reduction rules from top to bottom, and applying the first rule
that matches. Some rules (for 10 and +) appear to be in the wrong order:
a more general rule is above a more specific rule, making the latter
unreachable. It looks like this kind of issue has been around since Nock 8K.

To illustrate, I've modified the 5K spec. Perhaps that's heretical,
though! Let me know if I should have proposed a 4K spec, or done something

else.

You can merge this Pull Request by running

git pull https://github.com/ab9/urbit fix_nock_reduction_order

Or view, comment on, or merge it at:

#14
Commit Summary

• Fix reduction order in Nock spec

File Changes

• M Spec/nock/5.txthttps://github.com//pull/14/files#diff-0(4)

Patch Links:

• https://github.com/urbit/urbit/pull/14.patch
• https://github.com/urbit/urbit/pull/14.diff

from urbit.