Git Product home page Git Product logo

Comments (6)

giggio avatar giggio commented on May 3, 2024 1

I have worked around this issue by overwriting GITHUB_WORKFLOW env var: apache/avro@c635b9a

@martin-g this worked! I am using a matrix, so I had to use matrix values when setting GITHUB_WORKFLOW. Thanks for the tip!
giggio/node-chromedriver@8255bb5

from run-on-arch-action.

Grub4K avatar Grub4K commented on May 3, 2024 1

On the contrary I would like to use the same cache for different workflows. Instead of overwriting GITHUB_WORKFLOW I would want to allow specifying the full container name:

diff --git a/src/run-on-arch.js b/src/run-on-arch.js
index aeca1b2..ab4362c 100644
--- a/src/run-on-arch.js
+++ b/src/run-on-arch.js
@@ -100,7 +100,7 @@ async function main() {
   }
 
   // Generate a container name slug unique to this workflow
-  const containerName = slug([
+  const containerName = slug(core.getInput('containerName') || [
     'run-on-arch', env.GITHUB_REPOSITORY, env.GITHUB_WORKFLOW,
     arch, distro,
   ].join('-'));

That way more complex usecases could always specify the exact name they want to use and less complex ones can use the default. This solution should go well with #100 and allow a lot more flexibility.

from run-on-arch-action.

gotson avatar gotson commented on May 3, 2024

Example here: https://github.com/gotson/sqlite-jdbc/blob/0396dd33095d2045adef229a4530240d2f1f8a4f/.github/workflows/test.yml#L76

from run-on-arch-action.

giggio avatar giggio commented on May 3, 2024

I'm having the same problem. It does not fail but the cache is invalidated and rebuilt because of different node versions coming from the matrix.
Example: https://github.com/giggio/node-chromedriver/runs/5439981596?check_suite_focus=true

from run-on-arch-action.

martin-g avatar martin-g commented on May 3, 2024

I experience the same problem: https://github.com/apache/avro/blob/a6c82ac6f4d316e769059adab39a9b39b5ea9f8c/.github/workflows/test-arm64.yml

My workflow has several jobs which run the action in their steps. Since all jobs share the same Docker image they invalidate the image for each other.

from run-on-arch-action.

martin-g avatar martin-g commented on May 3, 2024

I have worked around this issue by overwriting GITHUB_WORKFLOW env var: apache/avro@c635b9a

from run-on-arch-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.