Git Product home page Git Product logo

Comments (21)

NayamAmarshe avatar NayamAmarshe commented on June 9, 2024 1

Upscayl NCNN has received the hotfix. If you want to fix it in Upscayl right now, here's what you can do:

  1. Download the latest upscayl-bin: https://github.com/upscayl/upscayl-ncnn/releases/tag/20240426-231028 and extract it somewhere. It should have a file called 'upscayl-bin'.
  2. Find where Upscayl is installed on your system. Find the folder called 'resources' which should have a 'bin' folder. For Mac, it would be in /Applications/Upscayl.app/Contents/Resources/binΒ΄

image

  1. Replace the 'upscayl-bin' file with the one you just downloaded in Step 1.

This should hopefully fix all issues with the custom width πŸ˜„

from upscayl.

xvim64 avatar xvim64 commented on June 9, 2024 1

Upscayl NCNN has received the hotfix. If you want to fix it in Upscayl right now, here's what you can do:

1. Download the latest upscayl-bin: https://github.com/upscayl/upscayl-ncnn/releases/tag/20240426-231028 and extract it somewhere. It should have a file called 'upscayl-bin'.

This should hopefully fix all issues with the custom width πŸ˜„

@NayamAmarshe

The hotfix works well on Windows 11 23H2.
Thank you for your hard work.

from upscayl.

aaronliu0130 avatar aaronliu0130 commented on June 9, 2024 1

Since the hotfix works, we should probably release a 2.11.1.

from upscayl.

NayamAmarshe avatar NayamAmarshe commented on June 9, 2024 1

Since the hotfix works, we should probably release a 2.11.1.

Ok, will do!

from upscayl.

StScAllen avatar StScAllen commented on June 9, 2024

Followup: Now when I try to rescale without custom settings I get a corrupted output:
slashers_upscayl_2x_ultramix_balanced

Reinstalling 2.10 once again cleared the issue.

from upscayl.

NayamAmarshe avatar NayamAmarshe commented on June 9, 2024

Seems like there's an issue with height calculation.

It's calculating the height as 1020x1465275732, which is why it's unable to write.

from upscayl.

NayamAmarshe avatar NayamAmarshe commented on June 9, 2024

I'd suggest using just the scale for now. I'll push a new update for custom width later.

from upscayl.

NayamAmarshe avatar NayamAmarshe commented on June 9, 2024

Also strange that it never actually calculates the height, otherwise it would have given an output.

https://github.com/upscayl/upscayl-ncnn/blob/41d6415db66e4b495fa96c65462eb48aa74377c1/src/main.cpp#L480

from upscayl.

NayamAmarshe avatar NayamAmarshe commented on June 9, 2024

@StScAllen Could you please share the image if possible? I am unable to reproduce the error.

image

from upscayl.

StScAllen avatar StScAllen commented on June 9, 2024

Absolutely. Image attached.
slashers

from upscayl.

vmackey avatar vmackey commented on June 9, 2024

I started using upscayl today, and I am having the exact same issue. I am trying to increase the image from 870x870 to 4500x4500. (I would share the image but my company won't allow it.) I'm glad there is an update planned to fix it, thanks.

from upscayl.

StScAllen avatar StScAllen commented on June 9, 2024

I started using upscayl today, and I am having the exact same issue. I am trying to increase the image from 870x870 to 4500x4500. (I would share the image but my company won't allow it.) I'm glad there is an update planned to fix it, thanks.

FYI - If you uninstall 2.11 and download and install 2.10 it will work fine. Nice changes in 2.11 but rolling back to 2.10 is not critical.

from upscayl.

vmackey avatar vmackey commented on June 9, 2024

I started using upscayl today, and I am having the exact same issue. I am trying to increase the image from 870x870 to 4500x4500. (I would share the image but my company won't allow it.) I'm glad there is an update planned to fix it, thanks.

FYI - If you uninstall 2.11 and download and install 2.10 it will work fine. Nice changes in 2.11 but rolling back to 2.10 is not critical.

Understood. Thank you for the tips.

from upscayl.

NayamAmarshe avatar NayamAmarshe commented on June 9, 2024

@StScAllen I'm unable to reproduce this issue on Mac:
image

from upscayl.

NayamAmarshe avatar NayamAmarshe commented on June 9, 2024

Huh, on Linux it throws an error. It's calculating the wrong height.
So the issue is on Linux and Windows.

image

from upscayl.

NayamAmarshe avatar NayamAmarshe commented on June 9, 2024

@aaronliu0130 the images don't stretch, they get corrupted. It takes int's upper value as the height for some strange reason.

from upscayl.

aaronliu0130 avatar aaronliu0130 commented on June 9, 2024

That may be the cause, but the visual effect in #794 (comment) (and in my testing) is that the image gets striated and stretched to the right.

from upscayl.

xvim64 avatar xvim64 commented on June 9, 2024

Windows 11 23H2
Upscayl 2.11.0

There are 2 symptoms.
--> no output
--> distorted

source

512x512
width512-source

width:1200, fast real-esrgan --> no output

width1200-output-fast-real-esrgan

width:1200, remarci --> distorted

not 1200x1200
width1200-output-demarci

from upscayl.

vnihouarn avatar vnihouarn commented on June 9, 2024

Hi,

I just wanted to confirm what xvim64 commented. Either no output or distorded. The height is wrong. A 768x768 image that I try to upscale to 4k is becoming a 4096x628. ;-(

Just wanted to say that your program is still really nice though. Having the custom width working would be so sweeeeeet!

from upscayl.

xcloudx01 avatar xcloudx01 commented on June 9, 2024

This should hopefully fix all issues with the custom width πŸ˜„

Legendary. Just confirming it's also fixed a bug for me where custom width images weren't saving. Now custom width images are working as expected. Thank you so much <3

from upscayl.

owen555999 avatar owen555999 commented on June 9, 2024

Upscayl NCNN has received the hotfix. If you want to fix it in Upscayl right now, here's what you can do:

  1. Download the latest upscayl-bin: https://github.com/upscayl/upscayl-ncnn/releases/tag/20240426-231028 and extract it somewhere. It should have a file called 'upscayl-bin'.
  2. Find where Upscayl is installed on your system. Find the folder called 'resources' which should have a 'bin' folder. For Mac, it would be in /Applications/Upscayl.app/Contents/Resources/binΒ΄

image

  1. Replace the 'upscayl-bin' file with the one you just downloaded in Step 1.

This should hopefully fix all issues with the custom width πŸ˜„

Thanks for hotfix

from upscayl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.