Opinion: changelog should contain each commit of PRs about github-changelog-generator HOT 5 CLOSED

Fixed 😂

from github-changelog-generator.

Related: #18

I also have that opinion.

from github-changelog-generator.

Related: #101

Is that a recursion joke? 😆

from github-changelog-generator.

we should add each commit since the last release, which might or not be associated to a PR.

This has the advantage of also making this module work even if one commited directly to master innocent.

For what my opinion's worth, I tend to agree with the common recommendation that all changes to a collaborative repository should happen via pull requests, as that improves visibility of the changes, allows them to be reviewed, and offers consistency between simple changes that only require a single commit and those that would be better split into multiple related (but independent) commits.

In fact, the good practice of atomic commits would precisely lead to commit messages that aren't necessarily a good fit for a changelog, since the latter should focus on whole features / functional changes / user stories, rather than the steps required to achieve them.

If anything, I would prefer seeing mechanisms in place to prevent commits made without PRs.

from github-changelog-generator.

@satazor since GitHub says that you closed this as "completed", could you confirm whether that is the case? I.e. did you make changes to this repo to enable commit-based changelogs, or did you simply use GitHub's default closing reason?

from github-changelog-generator.