Comments (5)
@uowuo Could we make something sensible with this? I have it working now, but I did not succeed in making it recognize ${prefix}/share/abaddon
path for resources – and had to dump the binary together with those two folders into a dedicated prefix. This is undesirable, though I could perhaps hack around that by adding a wrapper which would run from ${prefix}/bin
and pull everything from wherever.
from abaddon.
this is the part responsible for getting the resources directory
Lines 159 to 179 in 5e382b1
i didnt write it, but i think the macos code there is for when its in a .app form?
i can change it to check
ABADDON_RESOURCE_DIR
too. what would be the right way to determine ${prefix}
in your examples? on linux its $XDG_DATA_HOME
(usually $HOME/.local/share
). same thing?from abaddon.
i didnt write it, but i think the macos code there is for when its in a .app form?
Possibly (this is not something I understand well), but the build does not produce an app bundle.
If ABADDON_RESOURCE_DIR
can be passed to CMake so that is recognized and used by the build, that will solve the problem.
As a default value, I would expect a path relative to CMAKE_INSTALL_PREFIX
(which is either chosen by a package system or manually by a user). Usually it will be ${CMAKE_INSTALL_PREFIX}/share/${name}
for resources, or something similar. (As long as custom setting is possible, default behavior does not matter too much.)
If you would like the default installation to go into home folder, that can be done then by making it a default value for CMAKE_INSTALL_PREFIX
if it is not specified by a user.
P. S. I had to use wrappers to make this work, it is kinda ugly (though the first one, for libstdc++
case, is unavoidable):
https://github.com/macports/macports-ports/blob/d6a202a84122d1faa7105f2a360506343a93b81c/net/abaddon/Portfile#L107-L140
from abaddon.
Ouch, blame me haha. It's all been set up to work for it being packaged and me having no proper experience did it in a way that worked for me.
from abaddon.
I guess we need need this either to be configurable or the code to search for both (bundle paths and normal Unix paths).
from abaddon.
Related Issues (20)
- VC Leave/Join sounds
- Game activity detection support
- BUG: Token not fetched from INI file HOT 3
- libfmt version conflict causing the build to fail HOT 4
- ability to change your own and see other users pronouns HOT 1
- Silent message support HOT 2
- Token issue HOT 6
- Clang build crashes HOT 3
- Add rounded avatars HOT 1
- [Suggestion] Option to show only the channels of currently selected guild HOT 4
- Links colored black after PR #252 HOT 3
- No Audio at VC Move HOT 2
- Error while building (WINDOWS) HOT 8
- [remote-auth-ws] [error] Websocket error: Status: 0 Reason: Unable to connect to remote-auth-gateway.discord.gg on port 443, error: OpenSSL failed - error:0A000086:SSL routines::certificate verify failed HOT 2
- Install target does not install the main binary HOT 9
- macOS needs a several fixes for subprojects: how to do that, technically? HOT 2
- URI handler opens links and pictures in MS Word HOT 3
- Consider changing (removing) QR code colours. HOT 3
- Latest version ignores "mobile = true" ini flag HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abaddon.