Comments (7)
awkay
commented on August 15, 2024
Thanks, I'll have a look. Not sure when I can get to it.
If you wanted to have a look yourself, the code that places load markers is on line 31 of .../impl/data_fetch.cljs place-load-markers
from untangled-client.
awkay
commented on August 15, 2024
Note: Your code is setting marker to false, which means it should never set a fetch state marker there.
from untangled-client.
awkay
commented on August 15, 2024
More likely line 335 (in the error-callback remove-markers). That is placing error markers without checking to see if it is supposed to...so that actually is a bug.
from untangled-client.
mitchelkuijpers
commented on August 15, 2024
Yeah I also noted the marker: false I think I looked at the problem a bit too long. But it seems to still place the marker, as you noted.
from untangled-client.
mitchelkuijpers
commented on August 15, 2024
from untangled-client.
egracer
commented on August 15, 2024
@awkay I am patching this as we speak. Confirmed with @mitchelkuijpers that #22 and this issue are resolved with the same patch.
from untangled-client.
awkay
commented on August 15, 2024
@egracer Nice. Thanks!
from untangled-client.
Related Issues (20)
- Would like remote mutation response in post-mutation multimethod HOT 2
- Enhancement: Support viewer needs two kinds of compression
- Enhancement: Support viewer needs Facelift HOT 1
- Merging a not-found ident join crashes HOT 1
- Support externally supplied atom with InitialAppState
- Enhancement: Make it possible to have load-data place the load marker in custom app-state locations HOT 3
- Union queries with InitialAppState seem to break normalization with 0.5.8-SNAPSHOT HOT 3
- Enhancement: Support custom transit handlers HOT 1
- Links to untangled tutorial return 404 HOT 3
- Data fetch markers being left after union merge with no data HOT 2
- Merge of nested union's InitialAppState is broken HOT 1
- app state passed to global error callback does not have the `:untangled/server-error` in that app state. HOT 3
- Regression? 0.8.0-SNAPSHOT sweep merge might not be working HOT 1
- Allow custom reconciler options HOT 1
- `split-items-ready-to-load` reorders reads in the outgoing remote transaction HOT 2
- Feature: Ability to chain parsers HOT 1
- Bug: Loading by ident does not use proper merge HOT 1
- Load marker stomps on data if it's a not normalized map HOT 1
- remote same-named mutations in a single tx should be split to separate network requests HOT 1
- Devcards support hot code reload loses state HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from untangled-client.