Slow Performance with Svelte 5 about unplugin-icons HOT 10 OPEN

It seems faster from > 500ms to 136ms/230ms:

from unplugin-icons.

how can we test your repro? on my local I cannot see any performance slow down when loading the page.

Is it about running dev server or build + preview?

from unplugin-icons.

it seems to happen when running it in a mobile browser, like on chrome on android for example.

from unplugin-icons.

Can you try using passive modifier on click handler?.

Can you show performance details centered in 4s?

Can you check if lodash-es being tree shaked?

I always use the subpackage module, for example import sample from 'lodash-es/sample' instead loading from lodash-es barrel? I also include the subpackage in vite optimizedDeps.include array.

In dev or deployed app (build)?

from unplugin-icons.

Can you try using passive modifier on click handler?.

How do you do that?

Can you show performance details centered in 4s?

I'm not sure what you mean? Do you mean for me to screenshot the performance details for 4 seconds?

I always use the subpackage module, for example import sample from 'lodash-es/sample'

Does that make it faster?

In dev or deployed app (build)?

Both

I should be able to get to these tonight or tomorrow, will update here when I have more info

from unplugin-icons.

Does that make it faster?

It should, at least in dev server, check network tab (maybe the 600ms is about loading lodash-es barrel), I Will ckeck it tmr.

from unplugin-icons.

@SaintPepsi we've released v0.19.0 with Svelte 5 Runnes compiler, I'm going to check the performance on my mobile phone (Android 14)

from unplugin-icons.

About the lodash-es barrel, using your import in dev server lodash-es barrel chunk 256KB, using subpackage import + optimizedDeps.include ~12.5KB.

The passive event modifier is configured by Svelte 5 internally when safe.

from unplugin-icons.

Adding 25/100 children in the click handler is not cheap using any framework or even using VanillaJS, the problem seems not to be related to this repository, rather it seems like a problem with the logic in your reproduction.

from unplugin-icons.

@userquin I think you're right, I also posted it in svelte, also with a react example except it's not happening in react.
I'll try out v0.19.0 as well thanks

from unplugin-icons.