Git Product home page Git Product logo

Comments (7)

ivarconr avatar ivarconr commented on May 19, 2024

How should a strategy be defined?

Suggestion:

{
    "name": "activeForUser",
    "configurationTemplate": {
        "userNames": "string"
    }
}

from unleash.

Andersos avatar Andersos commented on May 19, 2024
{
    "strategy": "activeForUser",
    "enabled": false,
    "parameters": {
        "userNames": "string"
    }
}

Agree.
Enabled is default to false.
Parameters could be shortened to params.

from unleash.

jarib avatar jarib commented on May 19, 2024

I think parameters (or params) is inaccurate, and configurationTemplate is a lot more descriptive.

from unleash.

jarib avatar jarib commented on May 19, 2024

I think the template key here should match what we use in the feature, so either:

  1. use parametersTemplate in the strategy object, or
  2. rename parameters to configuration in the feature object

from unleash.

ivarconr avatar ivarconr commented on May 19, 2024

Thanks. I will keep it as parametersTemplate for simplicity.

from unleash.

Andersos avatar Andersos commented on May 19, 2024

We should do 2. as well =)

from unleash.

ivarconr avatar ivarconr commented on May 19, 2024

No. We must be concise.

  • The strategies define which parameters they require via the parametersTemplate
  • The feature toggles make use of a strategy and must fill the required parametes for that strategy.

from unleash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.