Git Product home page Git Product logo

Comments (2)

keilw avatar keilw commented on August 26, 2024

While this is for the inner class DefaultFormat, it should ideally be on UnitFormat along the lines of ServletContext and methods like setAttribute and removeAttribute, but we could leave such removeLabel (and for consistency also removeAlias) method available on SimpleUnitFormat for now.

As DefaultFormat should be made private or package-local in a future version, this doesn't make sense on its level.

Could be fixed by #396

from indriya.

keilw avatar keilw commented on August 26, 2024

I made a small adjustment, because unlike the label (which can only be set once, if set multiple times overwrites its "label" purpose and leaves the old one basically as an alias) aliases can be assigned multiple times. Therefore I redefined removeAlias() to remove a named alias (if present) while removeAliases() removes all aliases for a particular unit.

I added more tests to SimpleUnitFormatTest, the only thing I didn't call was removing the label/aliases from the "shared" instance, because it would break other tests, but if that's what you need in openHAB or elsewhere, you can use these methods accordingly.

from indriya.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.