Priority 2: Toolbox>accessibility analysis: import of external scenario about accessmod HOT 7 CLOSED

I can disable "autocomplete" button and report validation warning if provided table's:

1. mode column is not in "motorized, walking, bicycling".
2. number of classes and classes did not match merged landcover.
3. labels did not match those in merged landcover, excepted if the user imported a external merged landcover that doesn't contain labels (case of auto generated "no_label_1 ... no_label_n").

The user can still manually modify the processed table or copy and paste from a spreadsheet.

Do you need a milestone for this ?

from accessmod.

Ok for 1 and 2.

For 3 the labels in the imported table can indeed be different from the one in the merged landcover layer.

This is something conditional to be fixed before the release of the new version. Thanks

from accessmod.

I've replaced the button disabling function by a new way of merging by class comparison, together with a validation process message list (bellow external table in UI), so the user can still use a badly formatted table. Without this, there is too much case, where external table will not properly merge with the one extracted from merged land cover. I've tested with all the tables you provided to me, and it's working.

So, the function return a message list if something went wrong. Feel free to modify it.

if(noDataCheck) info <- c(info,"Empty field found")
if(!validMode) info <- c(info,paste("Some modes of transportation do not match currently allowed ones:",paste(names(config$listTranspMod),collapse=','),". Unknown  mode(s) will be changed to default value."))
if(!labelMatch) info <- c(info, "Some labels do not match those stored in the travel scenario to be processed and will overwrite them.")
if(!classMatch) info <- c(info, "Some classes do not match those stored in merged land cover and will not be imported.")

from accessmod.

I was actually thinking not to allow for a partial import but why not after all.

I will suggest some changes for the warning texts in the google spreadsheet.

Just one question, what do you mean by "default value" in the first message? does that correspond to the "MOTORIZED" mode?

Thanks

from accessmod.

Yes,

Default is MOTORIZED, but as I extract all the value from a list in config, I don't get a default value to write in the message. We can say that's the first item of the list (currently its "WALKING"): like this I can retrieve value by position.

That sounds correct for you ?

from accessmod.

If you mean that by default the value would be "WALKING" then that's fine with me.

The message would then read as follow then if I understand correctly: Some modes of transportation do not match currently allowed ones:",paste(names(config$listTranspMod),collapse=','),". Unknown mode(s) will be changed to "WALKING".

You can close this issue if this is indeed the case.

Thanks

from accessmod.

The change which has been made in the new version (249) is setting the unknown modes to "MOTORIZED" and not "WALKING" as per my previous message => many thanks in advance for adjusting this in both the system and the text (also reported in the google spreadsheet).

from accessmod.