CodeClimate configuration and rules about unibeautify HOT 7 CLOSED

For cognitive complexity problems, here is a good read: https://docs.codeclimate.com/docs/cognitive-complexity. private isDisabledAtLine and public static getOptionsForBeautifier methods both have a higher complexity than others.

from unibeautify.

The most important ones are file-lines, method-lines, similar-code, and identical-code. Beautifiers with a lot of options are going to have a lot of file lines. Depending on how the beautifier needs to be implemented, method lines could also grow (ex. https://github.com/Unibeautify/beautifier-prettydiff/blob/master/src/index.ts#L39-L113). Not to mention that Unibeautify CI may also break one line into multiple for easier reading.

We can also just leave as-is and mark Invalid or Wontfix in CodeClimate.

from unibeautify.

I've been marking some as Invalid and Wontfix.

Not to mention that Unibeautify CI may also break one line into multiple for easier reading.

Very good point. I've been increasing the max number of lines allowed in a function in linting rules for this reason.

from unibeautify.

Ah good call, maybe we should configure CodeClimate to use the same rules as TSLint (if possible). Here's what it currently looks like.

from unibeautify.

The beautifier.ts file really needs some love and to be split up. I did go through many of the methods a little while ago and reduce the complexity, however, there is still a lot of work to do.

from unibeautify.

Apart from getOptionsForBeautifier and optionKeys I think it is fine. Those two methods have a lot of conditionals and each has a forEach. That adds to the complexity.

I'm not sure why isDisabledAtLine is considered complex. I think we can remove the below since it will be handled by the return false at the end. Maybe that's all it's talking about?

if (disableIndex === -1) {
    return false;
}

Otherwise I'll start updating CodeClimate config files to what's specified in the above comment.

from unibeautify.

I updated all of the repos to have the same config. I'm going through and re-enabling the fixme plugin which is still useful. Otherwise I think we're at a good spot.

from unibeautify.