Git Product home page Git Product logo

Comments (4)

Cubik65536 avatar Cubik65536 commented on July 25, 2024 1

yep, I'm definitely in favor of removing the timestamp. I'm not entirely sure if they were added because CI was unstable or frequent rebuilds were needed, though

For now, we shouldn't need to rerun CIs unless we're changing the CI script and just want to test it. And I don't see any cases where there will be rebuilds (with the old script, it's possible that multiple releases will be created, it won't happen again).

I will make this change in the next update then.

from ungoogled-chromium-macos.

Cubik65536 avatar Cubik65536 commented on July 25, 2024

Yeah it is an unexpected problem to have it mismatched (I introduced this bug and haven't found it) and I do plan to remove these in the next update.

My plan is to just remove entirely the epoch timestamp from the release (from tag, title, and body), and also just use the chromium_version + ungoogled_revision (in this case, just the 121.0.6167.85-1.1) for both the tag and the release title, so that it behaves in the same way as the other repos in the org. (As mentioned here a bit (sort of))

Any opinions on this? /cc @networkException @PF4Public

from ungoogled-chromium-macos.

networkException avatar networkException commented on July 25, 2024

yep, I'm definitely in favor of removing the timestamp. I'm not entirely sure if they were added because CI was unstable or frequent rebuilds were needed, though

from ungoogled-chromium-macos.

claudiodekker avatar claudiodekker commented on July 25, 2024

yep, I'm definitely in favor of removing the timestamp. I'm not entirely sure if they were added because CI was unstable or frequent rebuilds were needed, though

They were added in #92, perhaps @kramred has any recollection of it if they're around?

from ungoogled-chromium-macos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.