Git Product home page Git Product logo

Comments (3)

ungoldman avatar ungoldman commented on September 22, 2024

I think detecting line endings would be better than creating a very unusual custom line endings option.

PRs welcome!

from changelog-parser.

jayxx1234 avatar jayxx1234 commented on September 22, 2024

I added the custom line endings option so that in (unusual) cases where the changelog uses multiple line endings (and you don't want the most common one), or line endings other than CR, LF, or CRLF, you have the ability to specify it yourself (I don't see this being a likely occurrence, but it was easy enough to add)

from changelog-parser.

bcomnes avatar bcomnes commented on September 22, 2024

I just ran the test suite on Mac windows and linux and it passed. Windows git does some wacky stuff with line endings, but if git for windows is configured right, it should work fine. Im nervous this adds additional complexity for what boils down to a misconfiguration with windows git.

If I understand correctly, this package currently assumes files will be using line endings appropriate for the OS its running on, and is choking when using line endings that don't match what the OS is set to use, to which the correct solution is, use line endings correct for the OS.

from changelog-parser.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.