Git Product home page Git Product logo

Comments (11)

lffg avatar lffg commented on May 13, 2024 14

Maybe we can create a monorepo (as Babel and even React.js do) with two initial packages:

  • packages/
    • unform
    • unform-react-native, which extends unform and adds other features.

To use in a React.js project (no breaking changes):

import { Form, Input } from "@rocketseat/unform";

// Do stuff.

And in a React Native project:

import { Form, Input, DatePicker ... } from "@rocketseat/unform-react-native";

// Do stuff.

from unform.

dudusotero avatar dudusotero commented on May 13, 2024 8

@lffg or can use something like styled-components do, using import {} from 'styled-components and import {} from 'styled-components/native

from unform.

italomlp avatar italomlp commented on May 13, 2024 1

I saw this discussion and I think that is not the responsibility of Unform to cares about date picker and other input types. So, my suggestion is to check if Unform is used in react native (or separate the files, like styled-components are), and so, provide properly components. For RN, only provides text Inputs (and Scope and Form too, as wrappers), and if the developer that is using Unform wants a Datepicker in the form, he can use the useField hook to register his own components.
What are your thoughts about this approach?

from unform.

dudusotero avatar dudusotero commented on May 13, 2024

But, could we begin some implementation without thinking outside TextInput's?

from unform.

diego3g avatar diego3g commented on May 13, 2024

@dudusotero Yeah, support for TextInput can be easily implemented. Maybe someone here can take it and open a PR.

from unform.

zaguiini avatar zaguiini commented on May 13, 2024

I personally don't think we should ship any inputs, only the interfaces to integrate the inputs as the user better desires. Sure, we might ship any logic to work with arrays and stuff, but apart from that everything is pretty much the same. Instead of shipping x components for x platforms, seems more practical/logical to ship only the base logic to implement one.

from unform.

zaguiini avatar zaguiini commented on May 13, 2024

I saw this discussion and I think that is not the responsibility of Unform to cares about date picker and other input types. So, my suggestion is to check if Unform is used in react native (or separate the files, like styled-components are), and so, provide properly components. For RN, only provides text Inputs (and Scope and Form too, as wrappers), and if the developer that is using Unform wants a Datepicker in the form, he can use the useField hook to register his own components.
What are your thoughts about this approach?

That's basically my suggestion :D A good one, I'd say!

from unform.

italomlp avatar italomlp commented on May 13, 2024

@zaguiini yeah. I mean, I agree with you and guess that it is a good approach to achieve Unform in RN.

from unform.

zaguiini avatar zaguiini commented on May 13, 2024

Not only RN, but for DOM as well. Making it simpler we could cut scope and areas of maintenance. That could be an extensions repository with all the custom inputs and stuff.

from unform.

douglaszaltron avatar douglaszaltron commented on May 13, 2024

+1

from unform.

diego3g avatar diego3g commented on May 13, 2024

Now we have support for React Native: https://unform.dev/guides/react-native

from unform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.