Comments (11)
Maybe we can create a monorepo (as Babel and even React.js do) with two initial packages:
- packages/
unform
unform-react-native
, which extendsunform
and adds other features.
To use in a React.js project (no breaking changes):
import { Form, Input } from "@rocketseat/unform";
// Do stuff.
And in a React Native project:
import { Form, Input, DatePicker ... } from "@rocketseat/unform-react-native";
// Do stuff.
from unform.
@lffg or can use something like styled-components do, using import {} from 'styled-components
and import {} from 'styled-components/native
from unform.
I saw this discussion and I think that is not the responsibility of Unform to cares about date picker and other input types. So, my suggestion is to check if Unform is used in react native (or separate the files, like styled-components are), and so, provide properly components. For RN, only provides text Inputs (and Scope and Form too, as wrappers), and if the developer that is using Unform wants a Datepicker in the form, he can use the useField
hook to register his own components.
What are your thoughts about this approach?
from unform.
But, could we begin some implementation without thinking outside TextInput's?
from unform.
@dudusotero Yeah, support for TextInput can be easily implemented. Maybe someone here can take it and open a PR.
from unform.
I personally don't think we should ship any inputs, only the interfaces to integrate the inputs as the user better desires. Sure, we might ship any logic to work with arrays and stuff, but apart from that everything is pretty much the same. Instead of shipping x
components for x
platforms, seems more practical/logical to ship only the base logic to implement one.
from unform.
I saw this discussion and I think that is not the responsibility of Unform to cares about date picker and other input types. So, my suggestion is to check if Unform is used in react native (or separate the files, like styled-components are), and so, provide properly components. For RN, only provides text Inputs (and Scope and Form too, as wrappers), and if the developer that is using Unform wants a Datepicker in the form, he can use the
useField
hook to register his own components.
What are your thoughts about this approach?
That's basically my suggestion :D A good one, I'd say!
from unform.
@zaguiini yeah. I mean, I agree with you and guess that it is a good approach to achieve Unform in RN.
from unform.
Not only RN, but for DOM as well. Making it simpler we could cut scope and areas of maintenance. That could be an extensions repository with all the custom inputs and stuff.
from unform.
+1
from unform.
Now we have support for React Native: https://unform.dev/guides/react-native
from unform.
Related Issues (20)
- Expo ImagePicker, DocumentPicker, Typescript example
- more informative error message when `useField` is being used in a component that's not a child of <Form>
- react-native-masked-text undefined field HOT 1
- error in the return oh the typing of the path
- TypeError: a is undefined
- Support middleware in getValue HOT 1
- formRef.current new key referring to form's html element
- The best way to create dynamic arrays with unform HOT 5
- need to add the css property to work correctly HOT 1
- How to get if a form is dirty? HOT 2
- Picker Select React Native
- edit form with setdata HOT 2
- Unform React Select Example Doc HOT 1
- Looking for some way to use unform in a <tr/> HOT 2
- Multiples Checkboxes whitin one form: HOT 1
- Access input value via useEffect
- How to get only data that have value HOT 1
- initialData not working HOT 3
- Persist Data HOT 6
- Radio Input with typecript HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unform.