[RFC] Reset form data about unform HOT 6 CLOSED

I was thinking something like clearOnSubmit prop inside <Form>, but I like yours better.

Should we reset form after submit automatically?

Personally I think that the form should not reset automatically. We should either provide a prop like clearOnSubmit or a helper like you suggested.

How edit cases would work? Clear data or return to initial data?

Perhaps we should offer the option to pass the data inside reset()? So if you need to return the state to its initial data you'd do reset(initialData), if empty, clears the inputs.

@diego3g could you provide an example of a situation where it might be needed to reset the inputs to its initial data (assuming they're populated, of course).

from unform.

@jpdemagalhaes Great, forgot about that! So let's keep with the helper idea, i think it's more readable and extendable as we are able to send params and have more helpers.

from unform.

@italoiz Great! We are looking into it. I've got the same problem in Jest but i managed to do it, but got some other problems with custom and select element. I got only input and textarea working for now. I'll probably send one PR until the weekend.

from unform.

Hmm, clearing a form with a button is possible with <input type="reset" />. It creates a button that when pressed clears all the inputs of the form, and when you have defaultValue, it returns to that state.

Which got me thinking. I feel like the only thing we should provide is clearOnSubmit prop, or like you suggested, a helper, which would be useful to reset the fields automatically after a submit. What do you think @diego3g ?

from unform.

I was making an implementation to reset the data after sending, passing a reset property that could be three types of values, they are:

1. string on-success. Only when the submission was successful.
2. string on-error. Only when an error occurs on the form.
3. string on-submit. In both cases above.

I stopped the feature when I saw this discussion.

My idea was following the logic of @jpdemagalhaes, but I was having trouble testing the call of a parameter that could be passed, the onReset. For some reason Jest could not identify.

Example:

<Form onReset={handleReset} reset="on-success" ... />

I had thought of a solution similar to that of @diego3g, I did not continue to think it was not so good when the other alternative. But seeing this discourse, realize that it is the best way.

For this reason, I believe that @diego3g solution is good.

from unform.

@jpdemagalhaes Great!

The example would be something like an reset button (is it still used?) inside the form near the submit. But i really think it's something we should not implement.

from unform.