Git Product home page Git Product logo

Comments (4)

julesghub avatar julesghub commented on July 30, 2024 1

Hi Peigen,

I suspect the error can be fixed by making this line.

if Model._advector:

include this condition
if Model._advector or Model._freeSurface:

Are you able to test this code locally with the change and your model?
I can make a branch/PR if this would help the above.

from underworld2.

julesghub avatar julesghub commented on July 30, 2024 1

Thanks for the test model. I have made a fix for the code.
I also made some light changes to the test code. Will push it now.

The changes I made are on the 2.14.x branch.
I'll create a 2.14.2b release soon to address the change.
In the meantime if you can try the code with the change, and let me know, that would be great.

from underworld2.

Peigen-L avatar Peigen-L commented on July 30, 2024 1

Hi Julian,

I think the change is working just fine.
Closing this issue.

from underworld2.

Peigen-L avatar Peigen-L commented on July 30, 2024

Hi Julian,

Here is the link for the free surface boundary condition testing:

https://github.com/underworld-community/Peigen-HPC/blob/30a31e09a41311e182e425a319d0633f020271c0/Free_surface.py#L568

I have another question with this line:

if Model._advector:
Model.mesh.load(os.path.join(self.restartDir, 'mesh-%s.h5' % step))
else:
Model.mesh.load(os.path.join(self.restartDir, "mesh.h5"))

Under this setting if Model.freeSurface = True the restarting model would load mesh.h5 then, which is not the case for the free surface condition as it should load mesh-step.h5

from underworld2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.