Git Product home page Git Product logo

Comments (3)

ChristopherChudzicki avatar ChristopherChudzicki commented on June 1, 2024

Option 1 seems simpler, so I lean toward that approach. The only disadvantage I can think of is that if all the examples use a CDN, it makes it slightly harder to manually test the examples for regressions. But... we can work around that, e.g., with a find-and-replace for temporary manual testing. Or better... include the examples in automated tests (like I started with curve). Anyway, I think that downside is acceptable and we can improve the manual regression testing situation later.

from mathbox.

sritchie avatar sritchie commented on June 1, 2024

I think that's great; including the examples in tests is the right long term move.

I bet we can get Github Actions to build the bundles on each PR and make the artifact available.

I also would love your thoughts on WHAT these bundles should be. I modified @unconed's original strategy of offering a monster bundle with all of three.js in it, and a mathbox-core with no dependencies. That is way easier for people to consume, but makes it not possible to pick a three.js version on your own.

At the same time, I have found issues with requirejs, or d3.require, not understanding that THREE needs to be installed as global THREE for OrbitControls etc to initialize.

So, this strategy is good, and I'm not sure of the best long-term path.

from mathbox.

sritchie avatar sritchie commented on June 1, 2024

Done!

from mathbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.