Comments (3)
Option 1 seems simpler, so I lean toward that approach. The only disadvantage I can think of is that if all the examples use a CDN, it makes it slightly harder to manually test the examples for regressions. But... we can work around that, e.g., with a find-and-replace for temporary manual testing. Or better... include the examples in automated tests (like I started with curve
). Anyway, I think that downside is acceptable and we can improve the manual regression testing situation later.
from mathbox.
I think that's great; including the examples in tests is the right long term move.
I bet we can get Github Actions to build the bundles on each PR and make the artifact available.
I also would love your thoughts on WHAT these bundles should be. I modified @unconed's original strategy of offering a monster bundle with all of three.js in it, and a mathbox-core with no dependencies. That is way easier for people to consume, but makes it not possible to pick a three.js version on your own.
At the same time, I have found issues with requirejs, or d3.require, not understanding that THREE needs to be installed as global THREE for OrbitControls etc to initialize.
So, this strategy is good, and I'm not sure of the best long-term path.
from mathbox.
Done!
from mathbox.
Related Issues (20)
- Add "Who is using mathbox?" docs HOT 1
- Add DEVELOPING.md, take a README pass HOT 1
- clean up "string continuations are not recommended" warnings HOT 1
- Internal functions occasionally make invalid css queries
- add more typedefs HOT 2
- Cannot select root HOT 4
- Update the jupyter notebook example to use current version HOT 4
- Surfaces are too dark HOT 7
- mathbox.debug throws an error
- Suggestion: scalar/complex fields HOT 2
- Update v1 mathbox readme to point here (not gitgud) HOT 1
- Formatting not working on CI
- docs are broken
- Bug when using mathbox + THREE.Color in a bundle HOT 7
- camelcase node ids do not work HOT 1
- get(k) on mathbox root ignores bound properties HOT 5
- RGBFormat removed from r137 HOT 4
- Readback example is broken HOT 3
- Any example code to make a 3D numbered spiral? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mathbox.