Documentation needs improvement. about django-cleanup HOT 8 CLOSED

Hi!
You don't need to use signals in this case.

from django-cleanup.

What I did is simply call os.remove(kwargs['file']) in my callback.

from django-cleanup.

The purpose of signals is to interact with third-party API's. If you don't need to interact with third parties then you don't need to use the signal interface. This library will handle the deletion of files for you (using django's File object API), you don't need to call os.remove yourself.

from django-cleanup.

@vinnyrose Hi, that is what I want but I can see that the test app explicitly deleted the file in the callback passed to the signal.

Can you then please tell me how I should use the signal if my model looks like the example above?

from django-cleanup.

For the model above, you don't need to use signals.

The code you are referencing in the test app is not explicitly deleting the file, it is calling an API function (delete) provided by sorl_thumbnail which deletes thumbnail files (related to but separate from the original file) and clears caches used internal in the sorl_thumbnail app.

The actual deletion of the original file happens here.

For most developers, including yourself, you simple pip install django-cleanup then add django_cleanup to INSTALLED_APPS and it will work as specified.

from django-cleanup.

@vinnyrose Oh that is it 😄Thank you!

from django-cleanup.

Hi!
You don't need to use signals in this case.

Maybe you can mention this in README, so that people will know for native app, it doesn't need to add any extra code to use this module.

Also, thanks for the super easy-to-use module! 😄

from django-cleanup.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from django-cleanup.