Error with cjs version of prettier-plugin-sql `Cannot read properties of undefined (reading 'parse')` about prettier HOT 7 CLOSED

Good idea, I'm happy to open a pr tomorrow with those changes (it's late UK time right now)

from prettier.

Would you like to raise a PR which will be appreciated!

from prettier.

Happy to help, however I don't have a proper fix yet other than directly modifying the bundled code. I think it might be a rollup config issue, I will spend some more time looking into how rollup is setup here

from prettier.

It needs to be changed to

const JSOX = typeof JSON
export = JSOX

And the ESM version should be changed accordingly.

You can juat raise the PR and I'll review and guide to finish.

from prettier.

https://github.com/d3x0r/JSOX/blob/44d2c55a1f0cfaf60f4b7f07f8565420f05498d0/package.jsox#L20-L24

https://github.com/d3x0r/JSOX/blob/44d2c55a1f0cfaf60f4b7f07f8565420f05498d0/lib/jsox.mjs#L3018

Interesting. This means it's an upstream issue actually...

cc @d3x0r

from prettier.

prettier/packages/sql/shim.d.ts

Line 2 in 3d85966

export const JSOX: typeof JSON

It needs to be changed to

const JSOX = typeof JSON

export = JSOX

And the ESM version should be changed accordingly.

You can juat raise the PR and I'll review and guide to finish.

Yep I tried this locally when I was investigating. It seems like import { JSOX } from 'jsox' is valid and in CommonJS it's var jsox = require('jsox'). I assumed they'd be something in roll up that could fix this for us. But you're right ideally it'd be fixed upstream

from prettier.

We need to support both of them at the same time.

// shim.d.ts
const JSOX: typeof JSON & { JSOX?: typeof JSON}

expot = JSOX

// index.ts
import * as _JSOX from 'jsox'

// workaround for inconsistent cjs/esm exports
const JSOX = _JSOX.JSOX || _JSOX

from prettier.