Git Product home page Git Product logo

Comments (8)

brucejk avatar brucejk commented on June 16, 2024

Hi,

Thank you for your compliment and for paying attention closely to the paper and code!

  1. In eq(4) in the second version of the paper, it says H_T^L, which stands for the target to the LiDAR.
  2. The refinement step still exists on another branch v1-2019. I also feel like it makes sense and reasonable. However, we were running out of space in the paper and even though the refinement step makes sense in practice, it still needs more verification and justification. We are working on that and will have a journal version of the paper soon.
  3. Could you tell me what you think X_at_lidar_frame should be? What you wrote is exactly the same in the code. To be more clear,
    a) L_X_transformed are the updated LiDAR vertices.
    b) C_X_transformed uses the original projection map to project back to the image plane and computes the first term of PnP cost.
    c) The latter term is the regularizer between point cloud vs camera. In other words, it is a confidence ratio between the point cloud vs the camera.

from extrinsic_lidar_camera_calibration.

yanliang-wang avatar yanliang-wang commented on June 16, 2024

Thanks for your reply!

  1. I am very sorry that my first question was wrongly described. I want to say that H_LT should be H_TL( i.e. lidar to target transformation) because PC in eq(4) is the points at LiDAR frame and I think that your eq(4) wants to compute the cost sum of each point at the target frame.

  2. Thanks for your reply to my curiosity!

  3. As the picture below shows, I think X_at_lidar_frame should be the blue part which is in eq(16) in the first version.
    X_at_lidar_frame
    I think if X_at_lidar_frame = inv(H_LT) * X, the yellow part in the picture below will be a constant, which won't change with theta_x, theta_y, theta_z and T.
    image

from extrinsic_lidar_camera_calibration.

brucejk avatar brucejk commented on June 16, 2024

Hi,

  1. Don't be sorry! Your description is correct but I think we might have different notation. To be clear, what we seek is the transformation from the physical tag to the LiDAR-ideal frame. Your LiDAR (target measured in LiDAR frame) to target (the ideal target frame at the LiDAR origin) should be the same as mine: the physical tag (measured in LiDAR frame) to the LiDAR-ideal frame (the ideal target frame at the LiDAR origin). In the paper, the H_T^L stands for from the physical tag to the LiDAR-ideal frame, which is correct! However, indeed, it is a bit confusing. I will think about it more. Thanks for pointing out!!

  2. Check!

  3. It is not a constant because it contains \delta H, which represents a slight correct on the optimized vertices. Back to the code, in the X_at_lidar_frame, please notice that, L_X_transformed includes the correction from the H. Please let me know if you think it is reasonable!

from extrinsic_lidar_camera_calibration.

yanliang-wang avatar yanliang-wang commented on June 16, 2024

Hi,

  1. OK! I also think we might have different notation.

  2. OK!

  3. I don't think X_at_lidar_frame contain \delta H. I noticed that L_X_transformed includes the correction from the H. In your code, you denote \delta H by H_LC, right?
    I notice that X_at_lidar_frame = inv(H_LT) * inv(H_LC) * L_X_transformed;, and L_X_transformed = H_LC * X; ,namely X_at_lidar_frame = inv(H_LT) * X;. So I don't think I don't think X_at_lidar_frame contain \delta H.

from extrinsic_lidar_camera_calibration.

brucejk avatar brucejk commented on June 16, 2024

Hi,

I have been pretty busy these days, sorry for the delay!

For #3, I think you are right and thanks for the correction! The code should simply be
X_at_lidar_frame = inv(H_LT) * L_X_transformed;

I will update the repo in a bit; please let me know if you have other concerns!

from extrinsic_lidar_camera_calibration.

yanliang-wang avatar yanliang-wang commented on June 16, 2024

Hi,

I sent my reply and new questions to your Gmail email, hope you can reply to me!

from extrinsic_lidar_camera_calibration.

brucejk avatar brucejk commented on June 16, 2024

Hi,

I do not get any emails from you tho. Which email address did you send to?
Did you send to [email protected]? If so, could you send it again?

from extrinsic_lidar_camera_calibration.

yanliang-wang avatar yanliang-wang commented on June 16, 2024

Yes, that's the email. Okay, I'll send it again

from extrinsic_lidar_camera_calibration.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.