Comments (5)
I know we've talked about doing this for a while but there still seems to be some inconsistencies about this:
- We still require this internally for the
IMembershipMemberService
with theSaveWithoutEvents
- It seems the package service still requires the
bool raiseEvents
overloads
Then the main question (for example) is as a developer: how do I use the ContentService.Saved
event to re-save the item and not cause an infinite loop? I know in most cases the answer is "dont" and use the Saving event to modify the data before it's persisted, but this will definitely happen and i know many devs are doing something like this today.
Is it possible to do this with a more consistent approach with some sort of scoping? Just as an API usage example:
using (EventScope.DisableEvents)
{
memberService.Save(member);
}
from umbraco-cms.
Very valid concerns indeed. I "just" removed the raiseEvents
parameter but forgot about that loop thing. And did not spend time on the package service at all. Of course an API-level solution (either, "disable events" or...) looks nicer. Kill this PR, will try again?
from umbraco-cms.
Right... the "right" way to do it ie either to disable events for a short while (but it has other problems, such as new events that should trigger) - or find a way to register what's happening in some sort of context, so ppl can determine whether they've already processed a given item.
=> requires thinking, design, whatever - moving back to backlog
from umbraco-cms.
This item has been added to our backlog AB#1279
from umbraco-cms.
Hiya @zpqrtbnk,
Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.
We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).
To open it this issue up again, you can write @umbrabot still relevant
in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.
For example:
@umbrabot still relevant
This bug can still be reproduced in version 8.9.0
This will reopen the issue in the next few hours.
Thanks, from your friendly Umbraco GitHub bot 🤖 🙂
from umbraco-cms.
Related Issues (20)
- Failed to acquire read lock for id: -335 HOT 8
- Strange behavior for validation of RTE inside a block list field HOT 4
- Old .cfs files are not deleted after Examine index rebuild. HOT 1
- BlockList: Cannot read properties of undefined (reading 'variants') HOT 2
- 13 LTS, latest Umbraco install only shows Sqlite, Sql Server missing. HOT 1
- uskinned builder breaks Umbraco 13 LTS HOT 2
- IDomain returns incorrect domain when wildcard is set to true HOT 1
- Backoffice search returns irrelevant results because Key is part of the search query HOT 1
- Umbraco breaks HttpAttribute HOT 1
- Datepicker doesn't allow pasting dates or manually typing dates HOT 1
- Saving a media-type with a rich-text property breaks the save media button HOT 2
- "Duplicate to..." does not work in v14 beta 2 HOT 2
- umbracoContextReference.UmbracoContext.Content.GetByContentType does not work with nodes that have VariByCulture set HOT 1
- Custom MVC routes should not go through all content finders HOT 3
- Clicking property name on TrueFalse property bypasses "shared across all languages" warning HOT 2
- appsettings.Local.json is not copied to output directory when using Umbraco.Cms.Tests.Integration HOT 1
- PostSave 403 Error on Save HOT 2
- When post operation takes long time, and the connection times out before the server returns a timeout or error, the error dialog shows "angular variables" instead of a message HOT 1
- Page with deleted doc type doesn't load HOT 1
- Save buttondisabled HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from umbraco-cms.