API changes Config about kge HOT 5 CLOSED

See also the discussion at the end of #43. Paraphrasing:

1+2. The purpose of get_option is to look at the right place in the current job/model/etc. It should stay and be used everywhere. Perhaps one could use a better name.

3+4 is good, but resolve_type is misleading (use resolve or resolve_via_type or allow_parent_lookup or sth along those lines)

from kge.

So your intention seems to be that config.get/set should not be called directly by non-core/internal stuff.

Then I would propose that the Config-object should be wrapped into a ConfigWrapper-class, which is then the gateway to config but checks and augments the config namespace.

class ConfigWrapper:
  def __init__(self, configuree, config):
    self._config_key = configuree.config_key
    self._config = config
  
  def get(... same as config.get ... ):
     do KgeModel.get_option stuff here and call.self._config.get

  def set(... same as config.set ... ):
     do KgeModel.set_option stuff here and call.self._config.set

and in the init of a job or model

self.config = ConfigWrapper(self, config)

from kge.

1. Merge get and get_default
2. Rename default to backoff_via_type or allow_parent_lookup and make a boolean argument get(..., backoff_via_type=True, ...) as it is done for set(..., create=True, ...). Then we have one get and one set with either an option to have a backoff_via_type/create behaviour or not.
3. Introduce a ConfigWrapper that exposes a get/set method that checks the config namespace of the current object and then calls the private config object.

from kge.

We had a quick discussion and the idea is to use a Configurable mixin. It has attributes config and configuration_key and provides methods get_option() and set_option().

This may also largely avoid the need for using self._init_configuration(config, configuration_key); instead, the Configurable constructor can be used.

from kge.

Addressed in 61e1243

from kge.