Code review: reimplementation of auto_initialization about kge HOT 5 CLOSED

Not a code review yet, but: the commit has a lot of junk (files ending on _old etc.), which should be removed.

As an aside: If things really need code review, it may be better to do it on a branch and then request the code review from there.

Generally, it's fine to use "auto" (that how I'd call the option) as an initializer. The code should check that all initializers are set to auto and that they are all lookup_embedders. For this there could be a utility function. The rest is model specific and thus belongs to the model, I think.

from kge.

Also, for models which support it, their main config file could set the initializers to auto (as it was before).

from kge.

Sorry about the junk, went with git add -A without thinking. Already cleaned them in fecf294

from kge.

Just to clarify: I think we should do the following changes

Generally, it's fine to use "auto" (that how I'd call the option) as an initializer. The code should check that all initializers are set to auto and that they are all lookup_embedders. For this there could be a utility function.

from kge.

Auto init has been dropped

from kge.