Git Product home page Git Product logo

Comments (6)

jwwq avatar jwwq commented on July 21, 2024 3

I can confirm that the fix works like a charm!

image

from undetected-chromedriver.

zxsleebu avatar zxsleebu commented on July 21, 2024 3

Thank you so much, man, for that fix!
I'm really tired of the fact that parsing a few hundred pages completely drains memory. Today I've narrowed down the leak to tab.query_selector (and hence to CDP call that returns items), but tired as hell, used a dirty hack with running nodriver in separate process to completely clear memory, did a reprex for the bug report, and without much hope, I entered "nodriver memory leak" and found your solution that you posted just two days ago! What a happy coincidence!

God bless you!

I'm glad I helped you and I really hope that the lead developer pushes this fix ASAP. thank you for the kind words!

from undetected-chromedriver.

jwwq avatar jwwq commented on July 21, 2024 1

Thank you so much, man, for that fix!
I'm really tired of the fact that parsing a few hundred pages completely drains memory. Today I've narrowed down the leak to tab.query_selector (and hence to CDP call that returns items), but tired as hell, used a dirty hack with running nodriver in separate process to completely clear memory, did a reprex for the bug report, and without much hope, I entered "nodriver memory leak" and found your solution that you posted just two days ago! What a happy coincidence!

God bless you!

from undetected-chromedriver.

ultrafunkamsterdam avatar ultrafunkamsterdam commented on July 21, 2024 1

this is implemented. thanks @zxsleebu

from undetected-chromedriver.

FDDQA avatar FDDQA commented on July 21, 2024

Unfortunately, this fix doesn't work. I also tried using a temporary file and adding a line to the library file - each time a browser.get(url) consumes about 100 KB. Also didn't help: page.close, page del, gc.collect(), etc.

from undetected-chromedriver.

zxsleebu avatar zxsleebu commented on July 21, 2024

this is implemented. thanks @zxsleebu

glad that you approved this fix. thanks for the library!

from undetected-chromedriver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.