Git Product home page Git Product logo

Comments (21)

uetchy avatar uetchy commented on May 25, 2024 3

The document for migrating from legacy extensions: https://developer.apple.com/documentation/safariservices/safari_app_extensions/converting_a_legacy_safari_extension_to_a_safari_app_extension

Safari Extension development guide:
https://developer.apple.com/documentation/safariservices/safari_app_extensions/building_a_safari_app_extension

from polyglot.

uetchy avatar uetchy commented on May 25, 2024 2

Pre-release version is out!
Leave a comment if you find a glitch.

from polyglot.

uetchy avatar uetchy commented on May 25, 2024 1

I won't fix #29 in this release because there are some difficulties lying down (e.g. difficulties on precise language detection and false negatives)

from polyglot.

uetchy avatar uetchy commented on May 25, 2024

Sadly, I have been away and don't have a chunk of time enough.
If someone is willing to contribute into Swift & Safari App Extension impl., it would be much appreciated! ☺️

The current code base is placed on mas branch.

from polyglot.

gingerbeardman avatar gingerbeardman commented on May 25, 2024

I think it's fairly low priority until Safari Extension gallery source is retired (WWDC/June? Public/October?

from polyglot.

uetchy avatar uetchy commented on May 25, 2024

Finally. About to ship this month.

Screen Shot 2019-07-07 at 3 36 23

from polyglot.

uetchy avatar uetchy commented on May 25, 2024

Screen Shot 2019-07-07 at 4 52 04

Screen Shot 2019-07-07 at 4 52 38

Upcoming dark/light mode and vibrancy support.

from polyglot.

gingerbeardman avatar gingerbeardman commented on May 25, 2024

Great work!

A few issues...

  1. I am seeing bad encoding on translated result when set to Auto Detect:

http://www.katch.ne.jp/~guts-2t86/game6.html
Screen shot 2019-07-07 at 11 13 56

http://sekaiyugi.com/games/hanafuda-1.html
Screen shot 2019-07-07 at 11 14 56

If I set Source Language to Japanese, display works OK:
Screen shot 2019-07-07 at 11 18 00

  1. BUT... translated text seems incorrect? seems to be coming from a source that is not the selected text or current window?

Compare Polyglot 2.6.0
Screen shot 2019-07-07 at 11 19 26

from polyglot.

gingerbeardman avatar gingerbeardman commented on May 25, 2024
  1. there is no way to bring Polyglot.app window back if it is closed using red dot. This will result in failed MAS submission in my experience with other Safari App Extensions.

Recommended solution: quit app on window close.

from polyglot.

uetchy avatar uetchy commented on May 25, 2024

@gingerbeardman Thank you for the super fast review!
Just fixed the Unicode related issue and updated pre-release tag. It should work now.

from polyglot.

uetchy avatar uetchy commented on May 25, 2024

Recommended solution: quit app on window close.

Added to ToDo

from polyglot.

gingerbeardman avatar gingerbeardman commented on May 25, 2024

Good Job!

Screen shot 2019-07-07 at 16 30 37

from polyglot.

gingerbeardman avatar gingerbeardman commented on May 25, 2024

Added to ToDo

AppDelegate.swift:

func applicationShouldTerminateAfterLastWindowClosed(_ sender: NSApplication) -> Bool {
    return true
}

edit: ah, you already did it!

from polyglot.

gingerbeardman avatar gingerbeardman commented on May 25, 2024

Problem reading text over dark background.
Screen shot 2019-07-07 at 20 31 34

Workaround is to select translated text
Screen shot 2019-07-07 at 20 31 29

from polyglot.

uetchy avatar uetchy commented on May 25, 2024

@gingerbeardman put more opacity on the panel. try the latest build and see if the issue is fixed.

from polyglot.

uetchy avatar uetchy commented on May 25, 2024

Screen Shot 2019-07-08 at 16 37 27

Screen Shot 2019-07-08 at 16 37 45

The latest build contains "synonyms" feature that displays related words during single word lookups.

from polyglot.

gingerbeardman avatar gingerbeardman commented on May 25, 2024

Even better than ever!

from polyglot.

gingerbeardman avatar gingerbeardman commented on May 25, 2024

Possible to catch some of the outstanding issues? Such as #29

from polyglot.

gingerbeardman avatar gingerbeardman commented on May 25, 2024

Synonym feature display seems small for me?

Screen shot 2019-07-08 at 11 35 15

from polyglot.

uetchy avatar uetchy commented on May 25, 2024

new build includes fixes on the font-size issue.

from polyglot.

uetchy avatar uetchy commented on May 25, 2024

Polyglot 3 is now available at Mac App Store and mas branch has been merged into master πŸš€
Huge thanks to all the contributors involved in this issue and Polyglot.

from polyglot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.