Error in injected.entry.js on line 8231 about polyglot HOT 6 CLOSED

I have same version of Polyglot and Safari however I couldn't reproduce the error.
What's your keyboard shortcuts settings?

This is my settings FYI:

from polyglot.

I have same key, but no keyboard modifier and that`s the key.

from polyglot.

It seems weird because I have no issue without keyboard modifiers.
Try to clear Key field and close the settings window, then put a new key to Key again and reload web pages.

from polyglot.

Hi, this issue appears to be related to:
https://stackoverflow.com/questions/46268576/angular-4-safari-settings-object-without-keyvalue-property-defined

In my case, the function seems to be blowing up because the settings object has no KeyValue assigned to it.

Please be very careful with this extension.
If key settings are not configured, the following code should not be blowing up:
function handleKeypress(e) {
var applyMeta = settings.useMetaKey ? e.metaKey : true;
var applyShift = settings.useShiftKey ? e.shiftKey : true;
var applyCtrl = settings.useCtrlKey ? e.ctrlKey : true;
var applyAlt = settings.useAltKey ? e.altKey : true;
var applyKey = settings.keyValue.charCodeAt(0) === e.keyCode; <------ Unless you know that settings.keyValue is always set. In my Safaria configuration, when I check the polyglot configuration, there seems to be no key bound.

	if (applyMeta && applyShift && applyCtrl && applyAlt && applyKey) {
		e.preventDefault();
		getSelectedText();
	}
}

On the console, my settings object looks as follows:
{targetLanguage: "en", useMetaKey: true} = $1

Even after trying to select a key setting (e.g. command) the configuration for the keyValue continues empty.

In the end, to work-around the issue, it was necessary to:
Make the key configuration to use the key: Shift + T

By updating the primary key setting and the key value, it seems like the polyglot configuration became good again and the error has now gone away.

Thanks.

from polyglot.

Updated to v2.1.0

• Suppress errors for invalid keyboard shortcuts

https://github.com/uetchy/Polyglot/releases/tag/v2.1.0

from polyglot.

See v2.2.0 for fixing this issue.

from polyglot.