Git Product home page Git Product logo

Comments (4)

doomspork avatar doomspork commented on May 28, 2024

@snewcomer I think this is a good idea and should be supported not just by this strategy but all of them. What do you think about that?

@hassox / @yordis we've talked about this a little, want to weigh in?

from ueberauth_twitter.

yordis avatar yordis commented on May 28, 2024

@doomspork this will be an issue, the best we do is exactly what @snewcomer propose.

Do we want to read the encoder from Ueberauth instead of the strategies?

If we add this to every single strategy will be hard to maintain for us, also for the end users since they would need to change it per strategy.

I would prefer to put json_library/0 in Ueberauth package and use it from the strategies. But I understand that it is a tradeoff since some people could ask for changing it only in specific strategies but at that moment I think they are not doing the right thing.

from ueberauth_twitter.

chulkilee avatar chulkilee commented on May 28, 2024

Seems like now you can use https://hexdocs.pm/ueberauth/0.6.3/Ueberauth.html#json_library/1

ueberauth/ueberauth#88

from ueberauth_twitter.

yordis avatar yordis commented on May 28, 2024

Yep

json_body = Ueberauth.json_library().decode!(response.body)

from ueberauth_twitter.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.