[Getting Familiar][Refactor] list out hardcodings in the preprocessors about omrchecker HOT 15 OPEN

can i be assigned to this one? ☺️

from omrchecker.

Line 336 in core.py
Score should be automatically evaluated but it currently hardcoded as a constant

After line 25 in CropOnMarkers
Hardcode: relativePath: “Omr_marker.jpg” are both set up in the template json samples – could this not be gotten from there?

From line 81 in CropPages
Hardcode: This could be passed in from the template configuration

Line 120 in imgutils.py
Hardcode: All the variables here are hard coded when it feels like these would be better as defaults that the user could change in config

Line 627 in imagutil.py
Hardcode: both x and y are hard coded when they should either be constants or configurable

Line 658 in imagutil.py
Hardcode: similar to the above, x and y have been hardcode.

Line 914 and 915 in imagutil.py
Hardcode: these should be constants or configurable

Other:

This is line is repeated in FeatureBasedAlignment, CropPages and imgutils– perhaps worth putting into a separate file and importing around to keep the code DRY?

From 125 in core.py
There is some unreachable logger code due to the return True.
Suggestion: Either the early return True is deleted or the logger code

from omrchecker.

@pranavajith please check discord for my reply.

from omrchecker.

from omrchecker.

@tuxo any updates?

from omrchecker.

Since @tuxo hasn't updated this issue in over a month, I thought I'd try it

from omrchecker.

I noticed some other minor issues apart from hardcoding I highlighted under other

from omrchecker.

Hi @GeorgiaMayDay, sorry I missed above comment. Will check soon. I hope you've joined over discord as well(I tend to respond quicker there)

from omrchecker.

I'm up for this challange, @Udayraj123 ..
Although some resources as to how to set hardcodings in preprocessors would be amazing.

from omrchecker.

Code is updated with some of the hardcodings reduced. New contributors can help here by checking for more hardcodings in the fresh code.

from omrchecker.

Hi @Udayraj123 I am happy to help. I will appreciate some resources if possible.

from omrchecker.

Hi @esing1201, good to know! You can setup the repo if you haven't and discuss if you face any issues.
This issue is about finding all hardcoded numbers in the repo and moving them into constants or config options, etc.

Please join over discord to get quicker replies :)

from omrchecker.

HI @Udayraj123 is the issue still open ?

from omrchecker.

Hi @rakeshcj, yes the issue is still open. Most of the hardcodings are in pre-processors that still need attention. Do let me know if you're picking it up!

from omrchecker.

Hi @rakeshcj let me know if any blockers.

from omrchecker.