[Get Familiar] Add schema validation for template configuration about omrchecker HOT 8 CLOSED

Hi @Udayraj123 , should the schema be created exactly for the template file mentioned here: Template File ?

from omrchecker.

That's correct. The same schema can also be found for all template.json files in samples folder

from omrchecker.

Would it be possible to get an example of an incorrect template file, I did write some code for the validation schema and error handling, but I'm not sure about the constraints to be put in my schema. Also, when I tried setting the dimensions in the sample template to 3, I expected an error but the code seemed to run fine. So, it would be helpful to know the expected constraints.

from omrchecker.

You can create incorrect template.json files by removing some of the mandatory keys, or changing their camelCase to TitleCase for keys(in which case validation error should mention that).
Setting 3rd dimension worked as code can run fine because it is written gracefully. Still we need the validation error to be thrown as a caution for future changes.

from omrchecker.

Have generated a draft PR, do let me know if this is what you were expecting.

from omrchecker.

@SpyzzVVarun discussed on discord. Let me know once all changes done..

from omrchecker.

Merged #60

from omrchecker.

extended in #65

from omrchecker.