Comments (10)
casperdcl
commented on June 15, 2024
Are we intending to replace it in all the other files where it's mentioned?
./documentation/STIR-developers-overview.tex
./documentation/release_2001_01_12.htm
./src/recon_buildblock/BackProjectorByBinUsingProjMatrixByBin.cxx
./src/recon_buildblock/BackProjectorByBinUsingInterpolation.cxx
./src/recon_buildblock/DataSymmetriesForBins.cxx
./src/recon_buildblock/ForwardProjectorByBinUsingProjMatrixByBin.cxx
./src/recon_buildblock/TrivialDataSymmetriesForBins.cxx
./src/recon_buildblock/ProjMatrixElemsForOneBin.cxx
./src/recon_buildblock/ProjMatrixElemsForOneDensel.cxx
./src/recon_buildblock/DataSymmetriesForDensels.cxx
./src/swig/stir.i
./src/recon_test/test_PoissonLogLikelihoodWithLinearModelForMeanAndProjData.cxx
./src/test/test_OutputFileFormat.cxx
./src/include/stir/ProjDataInMemory.h
./src/include/stir/doxygen_doc_for_boost.h
./src/include/stir/recon_buildblock/DataSymmetriesForBins.h
./src/include/stir/recon_buildblock/DataSymmetriesForBins_PET_CartesianGrid.inl
./src/include/stir/recon_buildblock/DataSymmetriesForBins_PET_CartesianGrid.h
./src/include/stir/recon_buildblock/ProjMatrixByBin.inl
./src/include/stir/recon_buildblock/DataSymmetriesForDensels.h
./src/include/stir/recon_buildblock/TrivialDataSymmetriesForBins.h
./src/include/stir/common.h
./src/include/stir/IO/ECAT962ListmodeInputFileFormat.h
./src/include/stir/IO/ECAT8_32bitListmodeInputFileFormat.h
./src/include/stir/IO/ECAT6ImageInputFileFormat.h
./src/include/stir/IO/ECAT7DynamicDiscretisedDensityInputFileFormat.h
./src/include/stir/IO/ITKImageInputFileFormat.h
./src/include/stir/IO/ECAT7ImageInputFileFormat.h
./src/include/stir/IO/InterfileImageInputFileFormat.h
./src/include/stir/IO/InputFileFormat.h
./src/include/stir/IO/ECAT966ListmodeInputFileFormat.h
./src/include/stir/IO/ROOTListmodeInputFileFormat.h
./src/include/stir/IO/read_from_file.h
./src/include/stir/is_null_ptr.h
./src/include/local/stir/recon_buildblock/DataSymmetriesForDensels_PET_CartesianGrid.inl
./src/include/local/stir/recon_buildblock/ProjMatrixByDensel.inl
./src/include/local/stir/recon_buildblock/DataSymmetriesForDensels_PET_CartesianGrid.h
./src/utilities/list_image_info.cxx
./src/utilities/stir_math.cxx
./src/iterative/OSMAPOSL/OSMAPOSLReconstruction.cxx
./src/iterative/OSSPS/OSSPSReconstruction.cxx
./src/IO/stir_ecat7.cxx
./src/IO/ECAT7DynamicDiscretisedDensityInputFileFormat.cxx
./src/IO/ITKImageInputFileFormat.cxx
./src/buildblock/ChainedDataProcessor.cxx
I haven't really looked into the code but unique_ptr sounds good to me. If files support multi-read and are not writable we may want a shared_ptr instead.
from stir.
KrisThielemans
commented on June 15, 2024
sure. we'd replace all of them. many occurences are just "local" (to make an pointer-object destruct). Replacing those is harmless of course. It's the ones in the class interface that will break backwards compatibility.
from stir.
KrisThielemans
commented on June 15, 2024
I've made now 2 attempts to get this to work (see 9dbc5fe) but still fail on OSX.
The issue is that OSX supplies a broken unique_ptr (even with C++-11!). See http://stackoverflow.com/questions/31655462/no-type-named-unique-ptr-in-namespace-std-when-compiling-under-llvm-clang.
I'm trying to replace it with a boost solution, see
https://github.com/UCL/STIR/blob/9dbc5fed3039d42731478ffdb6cb2357b0b70a86/src/include/stir/unique_ptr.h
This should have worked on Travis as its boost version is 1.61 while I require 1.57. However, it looks like it is still using the "desperate" fall-back of using a define (which I knew would fail). Can someone with a Mac investigate what's wrong with my preprocessor-ifs?
from stir.
KrisThielemans
commented on June 15, 2024
Anyone knows how to pass a flag to a specific compiler in Travis? We need to pass -stdlib=libc++ to clang on Apple for C++-11 (http://stackoverflow.com/questions/11853822/clang-3-1-cant-see-unique-ptr) but it won't work for Linux/gcc (presumably), and we don't want that flag when testing non-C++-11. @dvolgyes?
from stir.
dvolgyes
commented on June 15, 2024
I have just sent a pull request, hopefully, it will fix it.
The main point is this:
before_install:
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
EXTRA_BUILD_FLAGS="$EXTRA_BUILD_FLAGS -stdlib=libc++"; fi
It is a bit long and ugly, but as far as I know this is the idiomatic way.
Or if it fails, then similarly: CXXFLAGS="$CXXFLAGS -stdlib=libc++"
(I am not quite sure about cmake, and it takes a long time to test it,
so I had to guess, and I chose the first one. We will see soon.)
…On Tue, Dec 20, 2016 at 9:45 PM, Kris Thielemans ***@***.***> wrote:
Anyone knows how to pass a flag to a specific compiler in Travis? We need
to pass -stdlib=libc++ to clang on Apple for C++-11 (
http://stackoverflow.com/questions/11853822/clang-3-1-cant-see-unique-ptr)
but it won't work for Linux/gcc (presumably), and we don't want that flag
when testing non-C++-11. @dvolgyes <https://github.com/dvolgyes>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAZ-WEcnOoeT4l46pSwMx2YbzxNqiVt9ks5rKD5wgaJpZM4LJnNE>
.
from stir.
dvolgyes
commented on June 15, 2024
On second thought, probably this is the wrong enviromental variable,
and CXX_FLAGS is the way.
Another way: cmake could detect OSX, and setting variables accordingly.
See here:
http://public.kitware.com/pipermail/cmake/2012-September/052049.html
On Wed, Dec 21, 2016 at 5:49 AM, David Volgyes <[email protected]>
wrote:
… I have just sent a pull request, hopefully, it will fix it.
The main point is this:
before_install:
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then EXTRA_BUILD_FLAGS="$EXTRA_BUILD_FLAGS
-stdlib=libc++"; fi
It is a bit long and ugly, but as far as I know this is the idiomatic way.
Or if it fails, then similarly: CXXFLAGS="$CXXFLAGS -stdlib=libc++"
(I am not quite sure about cmake, and it takes a long time to test it,
so I had to guess, and I chose the first one. We will see soon.)
On Tue, Dec 20, 2016 at 9:45 PM, Kris Thielemans ***@***.***
> wrote:
> Anyone knows how to pass a flag to a specific compiler in Travis? We need
> to pass -stdlib=libc++ to clang on Apple for C++-11 (
> http://stackoverflow.com/questions/11853822/clang-3-1-cant-see-unique-ptr)
> but it won't work for Linux/gcc (presumably), and we don't want that flag
> when testing non-C++-11. @dvolgyes <https://github.com/dvolgyes>?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#63 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAZ-WEcnOoeT4l46pSwMx2YbzxNqiVt9ks5rKD5wgaJpZM4LJnNE>
> .
>
from stir.
dvolgyes
commented on June 15, 2024
It passed the test but I don't like it anymore, because it makes
the OSX & CERN_ROOT_SUPPORT part ugly in Travis' script section.
Unfortunatelly, I travel today, so if anybody has time or idea to continue
or finish it,
then please do it.
My current best guest is this:
we should modify the cmake config to detect OSX, and append the compiler
flag there.
The Travis build could be fixed with environment variable, but this will
not fix general OSX builds.
I think it would be better to detect OSX in Cmake, and in this case, append
an -stdlib=libc++
to the compiler flags.
On Wed, Dec 21, 2016 at 5:54 AM, David Volgyes <[email protected]>
wrote:
… On second thought, probably this is the wrong enviromental variable,
and CXX_FLAGS is the way.
Another way: cmake could detect OSX, and setting variables accordingly.
See here: http://public.kitware.com/pipermail/cmake/2012-
September/052049.html
On Wed, Dec 21, 2016 at 5:49 AM, David Volgyes ***@***.***>
wrote:
> I have just sent a pull request, hopefully, it will fix it.
> The main point is this:
> before_install:
> - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
> EXTRA_BUILD_FLAGS="$EXTRA_BUILD_FLAGS -stdlib=libc++"; fi
>
> It is a bit long and ugly, but as far as I know this is the idiomatic way.
> Or if it fails, then similarly: CXXFLAGS="$CXXFLAGS -stdlib=libc++"
> (I am not quite sure about cmake, and it takes a long time to test it,
> so I had to guess, and I chose the first one. We will see soon.)
>
>
> On Tue, Dec 20, 2016 at 9:45 PM, Kris Thielemans <
> ***@***.***> wrote:
>
>> Anyone knows how to pass a flag to a specific compiler in Travis? We
>> need to pass -stdlib=libc++ to clang on Apple for C++-11 (
>> http://stackoverflow.com/questions/11853822/clang-3-1-cant-
>> see-unique-ptr) but it won't work for Linux/gcc (presumably), and we
>> don't want that flag when testing non-C++-11. @dvolgyes
>> <https://github.com/dvolgyes>?
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#63 (comment)>, or mute
>> the thread
>> <https://github.com/notifications/unsubscribe-auth/AAZ-WEcnOoeT4l46pSwMx2YbzxNqiVt9ks5rKD5wgaJpZM4LJnNE>
>> .
>>
>
>
from stir.
KrisThielemans
commented on June 15, 2024
Thanks David. I think the option to detect OSX in Cmake is best, unless anyone knows if this would create trouble on OSX in certain situations?
By the way, I don't understand why Evgueni's last update occurs in your PR #64. I was already surprised I had to do an explicit merge of the CMakeExport branch on my side (should have been a fast-forward as far as I could tell). Did I create some trouble in git?
from stir.
casperdcl
commented on June 15, 2024
Yes, I'll probably find time to do it tonight if no one else does first.
…On 20 Dec 2016 9:46 p.m., "Kris Thielemans" ***@***.***> wrote:
Anyone knows how to pass a flag to a specific compiler in Travis? We need
to pass -stdlib=libc++ to clang on Apple for C++-11 (
http://stackoverflow.com/questions/11853822/clang-3-1-cant-see-unique-ptr)
but it won't work for Linux/gcc (presumably), and we don't want that flag
when testing non-C++-11. @dvolgyes <https://github.com/dvolgyes>?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKR9mw_c8tqAtpaYzUZlnqzzwzD_xbYnks5rKD5xgaJpZM4LJnNE>
.
from stir.
casperdcl
commented on June 15, 2024
Yes, CMake is the way, otherwise it'll only work on travis osx and not
other people's osx machines.
…On 21 Dec 2016 7:27 a.m., "David Volgyes" ***@***.***> wrote:
It passed the test but I don't like it anymore, because it makes
the OSX & CERN_ROOT_SUPPORT part ugly in Travis' script section.
Unfortunatelly, I travel today, so if anybody has time or idea to continue
or finish it,
then please do it.
My current best guest is this:
we should modify the cmake config to detect OSX, and append the compiler
flag there.
The Travis build could be fixed with environment variable, but this will
not fix general OSX builds.
I think it would be better to detect OSX in Cmake, and in this case, append
an -stdlib=libc++
to the compiler flags.
On Wed, Dec 21, 2016 at 5:54 AM, David Volgyes ***@***.***>
wrote:
> On second thought, probably this is the wrong enviromental variable,
> and CXX_FLAGS is the way.
>
> Another way: cmake could detect OSX, and setting variables accordingly.
> See here: http://public.kitware.com/pipermail/cmake/2012-
> September/052049.html
>
>
> On Wed, Dec 21, 2016 at 5:49 AM, David Volgyes ***@***.***>
> wrote:
>
>> I have just sent a pull request, hopefully, it will fix it.
>> The main point is this:
>> before_install:
>> - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
>> EXTRA_BUILD_FLAGS="$EXTRA_BUILD_FLAGS -stdlib=libc++"; fi
>>
>> It is a bit long and ugly, but as far as I know this is the idiomatic
way.
>> Or if it fails, then similarly: CXXFLAGS="$CXXFLAGS -stdlib=libc++"
>> (I am not quite sure about cmake, and it takes a long time to test it,
>> so I had to guess, and I chose the first one. We will see soon.)
>>
>>
>> On Tue, Dec 20, 2016 at 9:45 PM, Kris Thielemans <
>> ***@***.***> wrote:
>>
>>> Anyone knows how to pass a flag to a specific compiler in Travis? We
>>> need to pass -stdlib=libc++ to clang on Apple for C++-11 (
>>> http://stackoverflow.com/questions/11853822/clang-3-1-cant-
>>> see-unique-ptr) but it won't work for Linux/gcc (presumably), and we
>>> don't want that flag when testing non-C++-11. @dvolgyes
>>> <https://github.com/dvolgyes>?
>>>
>>> —
>>> You are receiving this because you were mentioned.
>>> Reply to this email directly, view it on GitHub
>>> <#63 (comment)>, or
mute
>>> the thread
>>> <https://github.com/notifications/unsubscribe-auth/AAZ-
WEcnOoeT4l46pSwMx2YbzxNqiVt9ks5rKD5wgaJpZM4LJnNE>
>>> .
>>>
>>
>>
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKR9mzziZ82aGiOR2wMAThOFdIqc2rEUks5rKMa5gaJpZM4LJnNE>
.
from stir.
Related Issues (20)
- problems with passing calibration info to exam_info of image
- scatter estimation problem in recon_test_pack
- ProjDataInfo::get_tof_bin out-of-range handling
- TOF loop missing for Hessian computation HOT 1
- MPI code likely still needs TOF changes
- ProjDataInfoGeneric et al need TOF changes
- TOF bin naming: timing_pos, timing_pos_num, TOF_bin?
- TOF support for GE is currently broken HOT 1
- TOF: CListEvent::delta_time should probably be removed
- tof mashing capability should probably be removed from ROOT
- TOF: sensitivity is currently calculated as non-TOF only for listmode recon
- make proj-data template optional for LmToProjData
- extra SWIG warnings on DetectionPosition*
- Need to add Germanium-68 to our radio-nuclide database HOT 1
- branching_ratio not taken into account in normalisation
- Feature suggestions for ProjData Visualization HOT 2
- Add get_non_tof_ProjData to ProjData
- TOF: compare_projdata doesn't loop over TOF
- Reading Siemens normalisation HOT 1
- reading Siemens interfile doesn't read "isotope name" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stir.