Comments (6)
additionally, the exposed readonly data providers and post processors have little value.
I'd like to remove these fields.
/**
* Ordered set of data providers that the data source was initialized with
*/
@property (nonatomic, readonly) NSOrderedSet<id<OHContactsDataProviderProtocol>> *dataProviders;
/**
* Ordered set of post processors that the data source was initialized with
*/
@property (nonatomic, readonly, nullable) NSOrderedSet<id<OHContactsPostProcessorProtocol>> *postProcessors;
from ohana-ios.
I disagree on the second post here, having access to the data providers is needed, post processors not so much
from ohana-ios.
I also propose making the onContactsDataSourceReadySignal actually fire a list of of contacts.
Sounds great to me!
from ohana-ios.
Might make more sense to move some of these headers into an extensions category that users can choose to pull in or not. That way we Don't have to delete them but they are not part of the top level API
from ohana-ios.
@maxwellE can you give an example where it's useful to expose the DataProviders here? I might be being daft but i'm not seeing the value in general, and more specifically i'm not understanding why the DataSource should be the one doing it. (If a consumer truly needs a DataProvider later, can they just hold it?)
from ohana-ios.
Also i'm heavily pro making the interface lean for understandability's sake, and if the properties are superfluous, moving them to a category doesn't change that.
If they're not superfluous we should, of course, keep them somehow.
from ohana-ios.
Related Issues (20)
- Unable to build when using CocoaPods with use_frameworks enabled
- Suggestions for persisting a collection of OHContacts? HOT 5
- Pod lint error in master
- Getting odd compile errors when using Ohana with BuddyBuild HOT 1
- Ohana should vend immutable models HOT 3
- Transition Example App to Swift 3
- Email Addresses Field? HOT 1
- Contact deduplication post-processor HOT 4
- Better documentation required for dataProviderDidHitContactsAuthenticationChallenge HOT 2
- Proposed modification/fix of PostProcessorProtocol HOT 4
- Travis is flakey HOT 2
- better threading docs required. & onContactsDataSourceReadySignal is not always dispatched to the main thread HOT 3
- major bump required to publish api change HOT 1
- should we remove contactsPassingFilter from the public API? HOT 2
- make the post processor API asynchronous HOT 1
- Errors connected with ownership qualifiers & copy HOT 2
- Can we extend the library to store it in any persistent data store HOT 1
- Sorting based on name and phone number only HOT 1
- Why there is no Subscription to onContactsDataProviderErrorSignal event in OHContactDataSource HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ohana-ios.