Git Product home page Git Product logo

Comments (3)

uazu avatar uazu commented on June 18, 2024

Okay, that would likely be useful for people using LCell. It would probably be best to add this as a Cargo feature. Is it just a matter of adding a new constructor to LCellOwner? I guess the existing LCell doc-tests would have to be duplicated for generativity.

from qcell.

CeleritasCelery avatar CeleritasCelery commented on June 18, 2024

it's just a matter of replacing LCellOwner::scope with LCellOwner::new, which takes a Guard. It could be behind a feature flag.

from qcell.

uazu avatar uazu commented on June 18, 2024

What I'm trying to ask is whether this is a simple add-on to the existing LCellOwner type, or whether it has to be a completely different type. It would be a breaking change to remove LCellOwner::scope. Looking at your fork, Id is a type from generativity. Generativity's Id has a couple of extra terms compared to qcell's, but the author doesn't explain why they are there. According to my reading of the Rustonomicon, they are not necessary, and they restrict UnwindSafe, so I think we should not use their Id. So the question is whether you can implement this as an addition, i.e. just add LCellOwner::new that accepts a generativity Guard. If that looks like it would work and be safe, I think this would be fine. I'd prefer it to be behind a feature flag so that people who don't need it don't get an extra dependency to consider in their safety review.

from qcell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.