Git Product home page Git Product logo

Comments (7)

u8sand avatar u8sand commented on May 24, 2024

I'm having a difficult time reproducing this, could you provide some more information:

  • how long it stays
  • how did you close the window (x, alt-f4, ?)
  • does baka-mplayer ever lag for you?
  • what sound server? (alsa, pulse oss)? so I can set it up and try to reproduce
  • just to make sure.. it doesn't happen with only mpv does it?

Thanks, it looks somewhat concerning like a leak, but I double checked the source--in particular i'm pretty sure mpv is getting cleaned up properly.

from baka-mplayer.

amazingfate avatar amazingfate commented on May 24, 2024

It seems that I also can't reproduce this,no matter by x,alt-f4,and ctrl+q.But the one I showed in the picture is still there, and there is no mpv running in my system. It will go away after loging out.
Baka-mplayer never lagged for me, it always runs perfect.
Sound server is ALSA.
With only mpv it doesn't happen.

from baka-mplayer.

amazingfate avatar amazingfate commented on May 24, 2024

Well I relogged in and tested, this problem happened again. It doesn't happen all the time. Sometimes it happens, sometimes it doesn't.

from baka-mplayer.

u8sand avatar u8sand commented on May 24, 2024

I'll leave this open for now but because I'm unable to reproduce it...

Let's just try something--it SHOULDN'T work but who knows.. Try this patch (to the latest commit):

diff --git a/src/ui/mainwindow.cpp b/src/ui/mainwindow.cpp
index 47b52f6..f42e94b 100644
--- a/src/ui/mainwindow.cpp
+++ b/src/ui/mainwindow.cpp
@@ -1184,6 +1184,7 @@ MainWindow::~MainWindow()
         delete dimDialog;
     if(moveTimer)
         delete moveTimer;
+    delete mpv;
     delete ui;
 }

qt is supposed to delete mpv, if not for some ridiculous reason this would take care of it.

from baka-mplayer.

amazingfate avatar amazingfate commented on May 24, 2024

I forgot to say that when I relogged in, baka-mplayer's window appeared. It should be the one that remained in the kmix. Maybe there was something wrong in my system since it is not easy to be reproduced. I'll try this patch someday.

from baka-mplayer.

amazingfate avatar amazingfate commented on May 24, 2024

I tried this patch and tested it for days, and it seems that it works. I suggest this patch added into the source code.

from baka-mplayer.

u8sand avatar u8sand commented on May 24, 2024

Ok thanks for the info, it means I should no longer trust Qt to delete objects for me. I'm glad your problem was fixed.

from baka-mplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.