strncpy faills to compile in ESP-IDF about ubxlib HOT 5 CLOSED

Hopefully fixed in b645c90.

from ubxlib.

You may need to add a buffer[sizeof(buffer)-1] = '\0' after as strncpy will not write beyond the size and add the zero termination if it does exceed.

That last char may have not been set before calling strncpy.

from ubxlib.

Hi, and thanks for posting. This is another one of those extremely irritating and quite pointless errors/warnings that GCC 8 introduced (the other one I'm aware of is with snprintf()): as you will see from the code, the buffer sizes already include room for a null terminator, there is no actual problem here, making this an error simply causes us to add more code (the buffer[sizeof(buffer)-1] = '\0' that Michael mentions) for no reason.

Let me see what is the simplest way to shut it up.

from ubxlib.

Actually, could you just try replacing strncpy with memcpy in these three locations? That should fix it.

from ubxlib.

I will close this one now: please feel free to re-open, or open a new issue, if there is more to discuss.

from ubxlib.